moxxy/moxxmpp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(xep): Fix cache issue with join/leaveRoom.

Browse Source 
Signed-off-by: Ikjot Singh Dhody <ikjotsd@gmail.com>
This commit is contained in:
Ikjot Singh Dhody 2023-06-20 17:38:30 +05:30
parent 51bca6c25d
commit 217c3ac236
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
packages/moxxmpp/lib/src/xeps/xep_0045/xep_0045.dart
View File

@ -45,7 +45,7 @@ class MUCManager extends XmppManagerBase {
}
Future<Result<bool, MUCError>> joinRoom(
JID roomJID,
JID roomJid,
String nick,
) async {
if (nick.isEmpty) {
@ -54,7 +54,7 @@ class MUCManager extends XmppManagerBase {
await getAttributes().sendStanza(
StanzaDetails(
Stanza.presence(
to: roomJID.withResource(nick).toString(),
to: roomJid.withResource(nick).toString(),
children: [
XMLNode.xmlns(
tag: 'x',
@ -66,28 +66,31 @@ class MUCManager extends XmppManagerBase {
);
await _cacheLock.synchronized(
() {
_mucRoomCache[roomJID]!.nick = nick;
_mucRoomCache[roomJid] = RoomState(roomJid: roomJid, nick: nick);
},
);
return const Result(true);
}
Future<Result<bool, MUCError>> leaveRoom(
JID roomJID,
JID roomJid,
) async {
final nick =
await _cacheLock.synchronized(() => _mucRoomCache[roomJID]!.nick);
final nick = await _cacheLock.synchronized(() {
final nick = _mucRoomCache[roomJid]?.nick;
_mucRoomCache.remove(roomJid);
return nick;
});
await getAttributes().sendStanza(
StanzaDetails(
Stanza.presence(
to: roomJID.withResource(nick!).toString(),
to: roomJid.withResource(nick!).toString(),
type: 'unavailable',
),
),
);
await _cacheLock.synchronized(
() {
_mucRoomCache.remove(roomJID);
_mucRoomCache.remove(roomJid);
},
);
return const Result(true);