Compare commits

..

2 Commits

3 changed files with 11 additions and 10 deletions

View File

@ -1 +1 @@
include: ../analysis_options.yaml
include: ../../analysis_options.yaml

View File

@ -1,4 +1,4 @@
include: ../analysis_options.yaml
include: ../../analysis_options.yaml
analyzer:
exclude:

View File

@ -50,11 +50,12 @@ class TCPSocketWrapper extends BaseSocketWrapper {
return <MoxSrvRecord>[];
}
bool _onBadCertificate(dynamic certificate, String domain) {
_log.fine('Bad certificate: ${certificate.toString()}');
//final isExpired = certificate.endValidity.isAfter(DateTime.now());
// TODO(Unknown): Either validate the certificate ourselves or use a platform native
// hostname verifier (or Dart adds it themselves)
/// Called when we encounter a certificate we cannot verify. [certificate] refers to the certificate
/// in question, while [domain] refers to the domain we try to validate the certificate against.
///
/// Return true if the certificate should be accepted. Return false if it should be rejected.
@visibleForOverriding
bool onBadCertificate(dynamic certificate, String domain) {
return false;
}
@ -83,7 +84,7 @@ class TCPSocketWrapper extends BaseSocketWrapper {
sock,
host: domain,
supportedProtocols: const [ xmppClientALPNId ],
onBadCertificate: (cert) => _onBadCertificate(cert, domain),
onBadCertificate: (cert) => onBadCertificate(cert, domain),
);
_ignoreSocketClosure = false;
@ -175,7 +176,7 @@ class TCPSocketWrapper extends BaseSocketWrapper {
_socket = await SecureSocket.secure(
_socket!,
supportedProtocols: const [ xmppClientALPNId ],
onBadCertificate: (cert) => _onBadCertificate(cert, domain),
onBadCertificate: (cert) => onBadCertificate(cert, domain),
);
_secure = true;