fix(core): Reset the connection tracker when timing out

packages/moxxmpp/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 - **BREAKING**: Removed `connectAwaitable` and merged it with `connect`.
 - **BREAKING**: Removed `allowPlainAuth` from `ConnectionSettings`. If you don't want to use SASL PLAIN, don't register the negotiator. If you want to only conditionally use SASL PLAIN, extend the `SaslPlainNegotiator` and override its `matchesFeature` method to only call the super method when SASL PLAIN should be used.
+- **BREAKING**: The user avatar's `subscribe` and `unsubscribe` no longer subscribe to the `:data` PubSub nodes
 
 ## 0.1.6+1
 

packages/moxxmpp/lib/src/connection.dart

@@ -600,6 +600,7 @@ class XmppConnection {
   /// Called when we timeout during connecting
   Future<void> _onConnectingTimeout() async {
     _log.severe('Connection stuck in "connecting". Causing a reconnection...');
+    await _resetIsConnectionRunning();
     await handleError(TimeoutError());
   }
 

packages/moxxmpp/lib/src/xeps/xep_0084.dart

@@ -163,7 +163,6 @@ class UserAvatarManager extends XmppManagerBase {
 
   /// Subscribe the data and metadata node of [jid].
   Future<Result<AvatarError, bool>> subscribe(String jid) async {
-    await _getPubSubManager().subscribe(jid, userAvatarDataXmlns);
     await _getPubSubManager().subscribe(jid, userAvatarMetadataXmlns);
 
     return const Result(true);
@@ -171,7 +170,6 @@ class UserAvatarManager extends XmppManagerBase {
 
   /// Unsubscribe the data and metadata node of [jid].
   Future<Result<AvatarError, bool>> unsubscribe(String jid) async {
-    await _getPubSubManager().unsubscribe(jid, userAvatarDataXmlns);
     await _getPubSubManager().subscribe(jid, userAvatarMetadataXmlns);
 
     return const Result(true);