feat: Bump moxxmpp version to 0.2.0

Fixes #11.

.woodpecker.yml

@@ -0,0 +1,28 @@
+pipeline:
+  # Check moxxmpp
+  moxxmpp-lint:
+    image: dart:2.18.1
+    commands:
+      - cd packages/moxxmpp
+      - dart pub get
+      - dart analyze --fatal-infos --fatal-warnings
+  moxxmpp-test:
+    image: dart:2.18.1
+    commands:
+      - cd packages/moxxmpp
+      - dart pub get
+      - dart test
+
+  # Check moxxmpp_socket_tcp
+  moxxmpp_socket_tcp-lint:
+    image: dart:2.18.1
+    commands:
+      - cd packages/moxxmpp_socket_tcp
+      - dart pub get
+      - dart analyze --fatal-infos --fatal-warnings
+  # moxxmpp-test:
+  #   image: dart:2.18.1
+  #   commands:
+  #     - cd packages/moxxmpp
+  #     - dart pub get
+  #     - dart test

packages/moxxmpp/lib/moxxmpp.dart

@@ -1,6 +1,7 @@
 library moxxmpp;
 
 export 'package:moxxmpp/src/connection.dart';
+export 'package:moxxmpp/src/connectivity.dart';
 export 'package:moxxmpp/src/errors.dart';
 export 'package:moxxmpp/src/events.dart';
 export 'package:moxxmpp/src/iq.dart';

packages/moxxmpp/lib/src/awaiter.dart

@@ -0,0 +1,94 @@
+import 'dart:async';
+import 'package:meta/meta.dart';
+import 'package:moxxmpp/src/jid.dart';
+import 'package:moxxmpp/src/stringxml.dart';
+import 'package:synchronized/synchronized.dart';
+
+/// A surrogate key for awaiting stanzas.
+@immutable
+class _StanzaSurrogateKey {
+  const _StanzaSurrogateKey(this.sentTo, this.id, this.tag);
+
+  /// The JID the original stanza was sent to. We expect the result to come from the
+  /// same JID.
+  final String sentTo;
+
+  /// The ID of the original stanza. We expect the result to have the same ID.
+  final String id;
+
+  /// The tag name of the stanza.
+  final String tag;
+  
+  @override
+  int get hashCode => sentTo.hashCode ^ id.hashCode ^ tag.hashCode;
+
+  @override
+  bool operator==(Object other) {
+    return other is _StanzaSurrogateKey &&
+           other.sentTo == sentTo &&
+           other.id == id &&
+           other.tag == tag;
+  }
+}
+
+/// This class handles the await semantics for stanzas. Stanzas are given a "unique"
+/// key equal to the tuple (to, id, tag) with which their response is identified.
+///
+/// That means that when sending ```<iq to="example@some.server.example" id="abc123" />```,
+/// the response stanza must be from "example@some.server.example", have id "abc123" and
+/// be an iq stanza.
+///
+/// This class also handles some "edge cases" of RFC 6120, like an empty "from" attribute.
+class StanzaAwaiter {
+  /// The pending stanzas, identified by their surrogate key.
+  final Map<_StanzaSurrogateKey, Completer<XMLNode>> _pending = {};
+
+  /// The critical section for accessing [StanzaAwaiter._pending].
+  final Lock _lock = Lock();
+
+  /// Register a stanza as pending.
+  /// [to] is the value of the stanza's "to" attribute.
+  /// [id] is the value of the stanza's "id" attribute.
+  /// [tag] is the stanza's tag name.
+  ///
+  /// Returns a future that might resolve to the response to the stanza.
+  Future<Future<XMLNode>> addPending(String to, String id, String tag) async {
+    final completer = await _lock.synchronized(() {
+      final completer = Completer<XMLNode>();
+      _pending[_StanzaSurrogateKey(to, id, tag)] = completer;
+      return completer;
+    });
+
+    return completer.future;
+  }
+
+  /// Checks if the stanza [stanza] is being awaited. [bareJid] is the bare JID of
+  /// the connection.
+  /// If [stanza] is awaited, resolves the future and returns true. If not, returns
+  /// false.
+  Future<bool> onData(XMLNode stanza, JID bareJid) async {
+    assert(bareJid.isBare(), 'bareJid must be bare');
+
+    final id = stanza.attributes['id'] as String?;
+    if (id == null) return false;
+    
+    final key = _StanzaSurrogateKey(
+      // Section 8.1.2.1 § 3 of RFC 6120 says that an empty "from" indicates that the
+      // attribute is implicitly from our own bare JID.
+      stanza.attributes['from'] as String? ?? bareJid.toString(),
+      id,
+      stanza.tag,
+    );
+
+    return _lock.synchronized(() {
+      final completer = _pending[key];
+      if (completer != null) {
+        _pending.remove(key);
+        completer.complete(stanza);
+        return true;
+      }
+
+      return false;
+    });
+  }
+}

packages/moxxmpp/lib/src/connection.dart

@@ -2,7 +2,9 @@ import 'dart:async';
 import 'package:logging/logging.dart';
 import 'package:meta/meta.dart';
 import 'package:moxlib/moxlib.dart';
+import 'package:moxxmpp/src/awaiter.dart';
 import 'package:moxxmpp/src/buffer.dart';
+import 'package:moxxmpp/src/connectivity.dart';
 import 'package:moxxmpp/src/errors.dart';
 import 'package:moxxmpp/src/events.dart';
 import 'package:moxxmpp/src/iq.dart';
@@ -89,49 +91,28 @@ class XmppConnectionResult {
   final XmppError? error;
 }
 
-/// A surrogate key for awaiting stanzas.
-@immutable
-class _StanzaAwaitableData {
-  const _StanzaAwaitableData(this.sentTo, this.id);
-
-  /// The JID the original stanza was sent to. We expect the result to come from the
-  /// same JID.
-  final String sentTo;
-
-  /// The ID of the original stanza. We expect the result to have the same ID.
-  final String id;
-
-  @override
-  int get hashCode => sentTo.hashCode ^ id.hashCode;
-
-  @override
-  bool operator==(Object other) {
-    return other is _StanzaAwaitableData &&
-           other.sentTo == sentTo &&
-           other.id == id;
-  }
-}
-
 /// This class is a connection to the server.
 class XmppConnection {
   XmppConnection(
     ReconnectionPolicy reconnectionPolicy,
+    ConnectivityManager connectivityManager,
     this._socket,
     {
       this.connectionPingDuration = const Duration(minutes: 3),
       this.connectingTimeout = const Duration(minutes: 2),
     }
-  ) : _reconnectionPolicy = reconnectionPolicy {
-      // Allow the reconnection policy to perform reconnections by itself
-      _reconnectionPolicy.register(
-        _attemptReconnection,
-        _onNetworkConnectionLost,
-      );
+  ) : _reconnectionPolicy = reconnectionPolicy,
+      _connectivityManager = connectivityManager {
+    // Allow the reconnection policy to perform reconnections by itself
+    _reconnectionPolicy.register(
+      _attemptReconnection,
+      _onNetworkConnectionLost,
+    );
 
-      _socketStream = _socket.getDataStream();
-      // TODO(Unknown): Handle on done
-      _socketStream.transform(_streamBuffer).forEach(handleXmlStream);
-      _socket.getEventStream().listen(_handleSocketEvent);
+    _socketStream = _socket.getDataStream();
+    // TODO(Unknown): Handle on done
+    _socketStream.transform(_streamBuffer).forEach(handleXmlStream);
+    _socket.getEventStream().listen(_handleSocketEvent);
   }
 
 
@@ -144,16 +125,18 @@ class XmppConnection {
   /// The data stream of the socket
   late final Stream<String> _socketStream;
 
-
   /// Connection settings
   late ConnectionSettings _connectionSettings;
 
   /// A policy on how to reconnect 
   final ReconnectionPolicy _reconnectionPolicy;
 
-  /// A list of stanzas we are tracking with its corresponding critical section lock
-  final Map<_StanzaAwaitableData, Completer<XMLNode>> _awaitingResponse = {};
-  final Lock _awaitingResponseLock = Lock();
+  /// The class responsible for preventing errors on initial connection due
+  /// to no network.
+  final ConnectivityManager _connectivityManager;
+
+  /// A helper for handling await semantics with stanzas
+  final StanzaAwaiter _stanzaAwaiter = StanzaAwaiter();
   
   /// Sorted list of handlers that we call or incoming and outgoing stanzas
   final List<StanzaHandler> _incomingStanzaHandlers = List.empty(growable: true);
@@ -240,63 +223,46 @@ class XmppConnection {
   /// none can be found.
   T? getNegotiatorById<T extends XmppFeatureNegotiatorBase>(String id) => _featureNegotiators[id] as T?;
   
-  /// Registers an [XmppManagerBase] sub-class as a manager on this connection.
-  /// [sortHandlers] should NOT be touched. It specified if the handler priorities
-  /// should be set up. The only time this should be false is when called via
-  /// [registerManagers].
-  void registerManager(XmppManagerBase manager, { bool sortHandlers = true }) {
-    _log.finest('Registering ${manager.getId()}');
-    manager.register(
-      XmppManagerAttributes(
-        sendStanza: sendStanza,
-        sendNonza: sendRawXML,
-        sendEvent: _sendEvent,
-        getConnectionSettings: () => _connectionSettings,
-        getManagerById: getManagerById,
-        isFeatureSupported: _serverFeatures.contains,
-        getFullJID: () => _connectionSettings.jid.withResource(_resource),
-        getSocket: () => _socket,
-        getConnection: () => this,
-        getNegotiatorById: getNegotiatorById,
-      ),
-    );
-
-    final id = manager.getId();
-    _xmppManagers[id] = manager;
-
-    if (id == discoManager) {
-      // NOTE: It is intentional that we do not exclude the [DiscoManager] from this
-      //       loop. It may also register features.
-      for (final registeredManager in _xmppManagers.values) {
-        (manager as DiscoManager).addDiscoFeatures(registeredManager.getDiscoFeatures());
-      }
-    } else if (_xmppManagers.containsKey(discoManager)) {
-      (_xmppManagers[discoManager]! as DiscoManager).addDiscoFeatures(manager.getDiscoFeatures());
-    }
-
-    _incomingStanzaHandlers.addAll(manager.getIncomingStanzaHandlers());
-    _incomingPreStanzaHandlers.addAll(manager.getIncomingPreStanzaHandlers());
-    _outgoingPreStanzaHandlers.addAll(manager.getOutgoingPreStanzaHandlers());
-    _outgoingPostStanzaHandlers.addAll(manager.getOutgoingPostStanzaHandlers());
-    
-    if (sortHandlers) {
-      _incomingStanzaHandlers.sort(stanzaHandlerSortComparator);
-      _incomingPreStanzaHandlers.sort(stanzaHandlerSortComparator);
-      _outgoingPreStanzaHandlers.sort(stanzaHandlerSortComparator);
-      _outgoingPostStanzaHandlers.sort(stanzaHandlerSortComparator);
-    }
-  }
-
-  /// Like [registerManager], but for a list of managers.
-  void registerManagers(List<XmppManagerBase> managers) {
+  /// Registers a list of [XmppManagerBase] sub-classes as managers on this connection.
+  Future<void> registerManagers(List<XmppManagerBase> managers) async {
     for (final manager in managers) {
-      registerManager(manager, sortHandlers: false);
+      _log.finest('Registering ${manager.id}');
+      manager.register(
+        XmppManagerAttributes(
+          sendStanza: sendStanza,
+          sendNonza: sendRawXML,
+          sendEvent: _sendEvent,
+          getConnectionSettings: () => _connectionSettings,
+          getManagerById: getManagerById,
+          isFeatureSupported: _serverFeatures.contains,
+          getFullJID: () => _connectionSettings.jid.withResource(_resource),
+          getSocket: () => _socket,
+          getConnection: () => this,
+          getNegotiatorById: getNegotiatorById,
+        ),
+      );
+
+      _xmppManagers[manager.id] = manager;
+
+      _incomingStanzaHandlers.addAll(manager.getIncomingStanzaHandlers());
+      _incomingPreStanzaHandlers.addAll(manager.getIncomingPreStanzaHandlers());
+      _outgoingPreStanzaHandlers.addAll(manager.getOutgoingPreStanzaHandlers());
+      _outgoingPostStanzaHandlers.addAll(manager.getOutgoingPostStanzaHandlers());
     }
 
     // Sort them
     _incomingStanzaHandlers.sort(stanzaHandlerSortComparator);
+    _incomingPreStanzaHandlers.sort(stanzaHandlerSortComparator);
     _outgoingPreStanzaHandlers.sort(stanzaHandlerSortComparator);
     _outgoingPostStanzaHandlers.sort(stanzaHandlerSortComparator);
+
+    // Run the post register callbacks
+    for (final manager in _xmppManagers.values) {
+      if (!manager.initialized) {
+        _log.finest('Running post-registration callback for ${manager.name}');
+        await manager.postRegisterCallback();
+      }
+    }
   }
   
   /// Register a list of negotiator with the connection.
@@ -401,7 +367,7 @@ class XmppConnection {
     // Connect again
     // ignore: cascade_invocations
     _log.finest('Calling connect() from _attemptReconnection');
-    await connect();
+    await connect(waitForConnection: true);
   }
   
   /// Called when a stream ending error has occurred
@@ -424,7 +390,11 @@ class XmppConnection {
       return;
     }
 
-    await _setConnectionState(XmppConnectionState.error);
+    if (await _connectivityManager.hasConnection()) {
+      await _setConnectionState(XmppConnectionState.error);
+    } else {
+      await _setConnectionState(XmppConnectionState.notConnected);
+    }
     await _reconnectionPolicy.onFailure();
   }
 
@@ -482,7 +452,7 @@ class XmppConnection {
   /// If addId is true, then an 'id' attribute will be added to the stanza if [stanza] has
   /// none.
   // TODO(Unknown): if addId = false, the function crashes.
-  Future<XMLNode> sendStanza(Stanza stanza, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool awaitable = true, bool encrypted = false }) async {
+  Future<XMLNode> sendStanza(Stanza stanza, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool awaitable = true, bool encrypted = false, bool forceEncryption = false, }) async {
     assert(implies(addId == false && stanza.id == null, !awaitable), 'Cannot await a stanza with no id');
 
     // Add extra data in case it was not set
@@ -513,6 +483,7 @@ class XmppConnection {
         null,
         stanza_,
         encrypted: encrypted,
+        forceEncryption: forceEncryption,
       ),
     );
     _log.fine('Done');
@@ -544,43 +515,38 @@ class XmppConnection {
     _log.fine('Attempting to acquire lock for ${data.stanza.id}...');
     // TODO(PapaTutuWawa): Handle this much more graceful
     var future = Future.value(XMLNode(tag: 'not-used'));
-    await _awaitingResponseLock.synchronized(() async {
-      _log.fine('Lock acquired for ${data.stanza.id}');
-
-      _StanzaAwaitableData? key;
-      if (awaitable) {
-        key = _StanzaAwaitableData(data.stanza.to!, data.stanza.id!);
-        _awaitingResponse[key] = Completer();
-      }
-
-      // This uses the StreamManager to behave like a send queue
-      if (await _canSendData()) {
-        _socket.write(stanzaString);
-
-        // Try to ack every stanza
-        // NOTE: Here we have send an Ack request nonza. This is now done by StreamManagementManager when receiving the StanzaSentEvent
-      } else {
-        _log.fine('_canSendData() returned false.');
-      }
-
-      _log.fine('Running post stanza handlers..');
-      await _runOutgoingPostStanzaHandlers(
-        stanza_,
-        initial: StanzaHandlerData(
-          false,
-          false,
-          null,
-          stanza_,
-        ),
+    if (awaitable) {
+      future = await _stanzaAwaiter.addPending(
+        // A stanza with no to attribute is for direct processing by the server. As such,
+        // we can correlate it by just *assuming* we have that attribute
+        // (RFC 6120 Section 8.1.1.1)
+        data.stanza.to ?? _connectionSettings.jid.toBare().toString(),
+        data.stanza.id!,
+        data.stanza.tag,
       );
-      _log.fine('Done');
+    }
 
-      if (awaitable) {
-        future = _awaitingResponse[key]!.future;
-      }
+    // This uses the StreamManager to behave like a send queue
+    if (await _canSendData()) {
+      _socket.write(stanzaString);
 
-      _log.fine('Releasing lock for ${data.stanza.id}');
-    });
+      // Try to ack every stanza
+      // NOTE: Here we have send an Ack request nonza. This is now done by StreamManagementManager when receiving the StanzaSentEvent
+    } else {
+      _log.fine('_canSendData() returned false.');
+    }
+
+    _log.fine('Running post stanza handlers..');
+    await _runOutgoingPostStanzaHandlers(
+      stanza_,
+      initial: StanzaHandlerData(
+        false,
+        false,
+        null,
+        stanza_,
+      ),
+    );
+    _log.fine('Done');
 
     return future;
   }
@@ -744,21 +710,10 @@ class XmppConnection {
       '';
     _log.finest('<== $prefix${incomingPreHandlers.stanza.toXml()}');
 
-    // See if we are waiting for this stanza
-    final id = incomingPreHandlers.stanza.attributes['id'] as String?;
-    var awaited = false;
-    await _awaitingResponseLock.synchronized(() async {
-      if (id != null && incomingPreHandlers.stanza.from != null) {
-        final key = _StanzaAwaitableData(incomingPreHandlers.stanza.from!, id);
-        final comp = _awaitingResponse[key];
-        if (comp != null) {
-          comp.complete(incomingPreHandlers.stanza);
-          _awaitingResponse.remove(key);
-          awaited = true;
-        }
-      }
-    });
-
+    final awaited = await _stanzaAwaiter.onData(
+      incomingPreHandlers.stanza,
+      _connectionSettings.jid.toBare(),
+    );
     if (awaited) {
       return;
     }
@@ -776,7 +731,7 @@ class XmppConnection {
       ),
     );
     if (!incomingHandlers.done) {
-      handleUnhandledStanza(this, incomingPreHandlers.stanza);
+      await handleUnhandledStanza(this, incomingPreHandlers);
     }
   }
 
@@ -870,7 +825,6 @@ class XmppConnection {
         if (_isMandatoryNegotiationDone(_streamFeatures) && !_isNegotiationPossible(_streamFeatures)) {
           _log.finest('Negotiations done!');
           _updateRoutingState(RoutingState.handleStanzas);
-          await _reconnectionPolicy.onSuccess();
           await _resetIsConnectionRunning();
           await _onNegotiationsDone();
         } else {
@@ -895,7 +849,6 @@ class XmppConnection {
         _log.finest('Negotiations done!');
 
         _updateRoutingState(RoutingState.handleStanzas);
-        await _reconnectionPolicy.onSuccess();
         await _resetIsConnectionRunning();
         await _onNegotiationsDone();
       } else {
@@ -913,7 +866,6 @@ class XmppConnection {
       _log.finest('Negotiator wants to skip the remaining negotiation... Negotiations (assumed) done!');
 
       _updateRoutingState(RoutingState.handleStanzas);
-      await _reconnectionPolicy.onSuccess();
       await _resetIsConnectionRunning();
       await _onNegotiationsDone();
       break;
@@ -1025,7 +977,7 @@ class XmppConnection {
   }
 
   Future<void> _disconnect({required XmppConnectionState state, bool triggeredByUser = true}) async {
-    _reconnectionPolicy.setShouldReconnect(false);
+    await _reconnectionPolicy.setShouldReconnect(false);
 
     if (triggeredByUser) {
       getPresenceManager().sendUnavailablePresence();
@@ -1056,17 +1008,21 @@ class XmppConnection {
   
   /// Like [connect] but the Future resolves when the resource binding is either done or
   /// SASL has failed.
-  Future<XmppConnectionResult> connectAwaitable({ String? lastResource }) async {
+  Future<XmppConnectionResult> connectAwaitable({ String? lastResource, bool waitForConnection = false }) async {
     _runPreConnectionAssertions();
     await _resetIsConnectionRunning();
     _connectionCompleter = Completer();
     _log.finest('Calling connect() from connectAwaitable');
-    await connect(lastResource: lastResource);
+    await connect(
+      lastResource: lastResource,
+      waitForConnection: waitForConnection,
+      shouldReconnect: false,
+    );
     return _connectionCompleter!.future;
   }
  
   /// Start the connection process using the provided connection settings.
-  Future<void> connect({ String? lastResource }) async {
+  Future<void> connect({ String? lastResource, bool waitForConnection = false, bool shouldReconnect = true }) async {
     if (_connectionState != XmppConnectionState.notConnected && _connectionState != XmppConnectionState.error) {
       _log.fine('Cancelling this connection attempt as one appears to be already running.');
       return;
@@ -1074,15 +1030,25 @@ class XmppConnection {
     
     _runPreConnectionAssertions();
     await _resetIsConnectionRunning();
-    _reconnectionPolicy.setShouldReconnect(true);
     
     if (lastResource != null) {
       setResource(lastResource);
     }
 
+    if (shouldReconnect) {
+      await _reconnectionPolicy.setShouldReconnect(true);
+    }
+
     await _reconnectionPolicy.reset();
     await _sendEvent(ConnectingEvent());
 
+    // If requested, wait until we have a network connection
+    if (waitForConnection) {
+      _log.info('Waiting for okay from connectivityManager');
+      await _connectivityManager.waitForConnection();
+      _log.info('Got okay from connectivityManager');
+    }
+    
     final smManager = getStreamManagementManager();
     String? host;
     int? port;

packages/moxxmpp/lib/src/connectivity.dart

@@ -0,0 +1,18 @@
+/// This manager class is responsible to tell the moxxmpp XmppConnection
+/// when a connection can be established or not, regarding the network availability.
+abstract class ConnectivityManager {
+  /// Returns true if a network connection is available. If not, returns false.
+  Future<bool> hasConnection();
+
+  /// Returns a future that resolves once we have a network connection.
+  Future<void> waitForConnection();
+}
+
+/// An implementation of [ConnectivityManager] that is always connected.
+class AlwaysConnectedConnectivityManager extends ConnectivityManager {
+  @override
+  Future<bool> hasConnection() async => true;
+
+  @override
+  Future<void> waitForConnection() async {}
+}

packages/moxxmpp/lib/src/iq.dart

@@ -1,10 +1,28 @@
 import 'package:moxxmpp/src/connection.dart';
+import 'package:moxxmpp/src/managers/data.dart';
 import 'package:moxxmpp/src/stanza.dart';
 
-bool handleUnhandledStanza(XmppConnection conn, Stanza stanza) {
-  if (stanza.type != 'error' && stanza.type != 'result') {
-    conn.sendStanza(stanza.errorReply('cancel', 'feature-not-implemented'));
-  }
+/// Bounce a stanza if it was not handled by any manager. [conn] is the connection object
+/// to use for sending the stanza. [data] is the StanzaHandlerData of the unhandled
+/// stanza.
+Future<void> handleUnhandledStanza(XmppConnection conn, StanzaHandlerData data) async {
+  if (data.stanza.type != 'error' && data.stanza.type != 'result') {
+    final stanza = data.stanza.copyWith(
+      to: data.stanza.from,
+      from: data.stanza.to,
+      type: 'error',
+      children: [
+        buildErrorElement(
+          'cancel',
+          'feature-not-implemented',
+        ),
+      ],
+    );
 
-  return true;
+    await conn.sendStanza(
+      stanza,
+      awaitable: false,
+      forceEncryption: data.encrypted,
+    );
+  }
 }

packages/moxxmpp/lib/src/jid.dart

@@ -51,7 +51,11 @@ class JID {
   bool isFull() => resource.isNotEmpty;
 
   /// Converts the JID into a bare JID.
-  JID toBare() => JID(local, domain, '');
+  JID toBare() {
+    if (isBare()) return this;
+    
+    return JID(local, domain, '');
+  }
 
   /// Converts the JID into one with a resource part of [resource].
   JID withResource(String resource) => JID(local, domain, resource);

packages/moxxmpp/lib/src/managers/attributes.dart

@@ -23,7 +23,7 @@ class XmppManagerAttributes {
     required this.getNegotiatorById,
   });
   /// Send a stanza whose response can be awaited.
-  final Future<XMLNode> Function(Stanza stanza, { StanzaFromType addFrom, bool addId, bool awaitable, bool encrypted}) sendStanza;
+  final Future<XMLNode> Function(Stanza stanza, { StanzaFromType addFrom, bool addId, bool awaitable, bool encrypted, bool forceEncryption}) sendStanza;
 
   /// Send a nonza.
   final void Function(XMLNode) sendNonza;

packages/moxxmpp/lib/src/managers/base.dart

@@ -1,17 +1,27 @@
 import 'package:logging/logging.dart';
+import 'package:meta/meta.dart';
 import 'package:moxxmpp/src/events.dart';
 import 'package:moxxmpp/src/managers/attributes.dart';
+import 'package:moxxmpp/src/managers/data.dart';
 import 'package:moxxmpp/src/managers/handlers.dart';
+import 'package:moxxmpp/src/managers/namespaces.dart';
 import 'package:moxxmpp/src/stringxml.dart';
+import 'package:moxxmpp/src/xeps/xep_0030/types.dart';
+import 'package:moxxmpp/src/xeps/xep_0030/xep_0030.dart';
 
 abstract class XmppManagerBase {
+  XmppManagerBase(this.id);
+
   late final XmppManagerAttributes _managerAttributes;
   late final Logger _log;
 
+  /// Flag indicating that the post registration callback has been called once.
+  bool initialized = false;
+  
   /// Registers the callbacks from XmppConnection with the manager
   void register(XmppManagerAttributes attributes) {
     _managerAttributes = attributes;
-    _log = Logger(getName());
+    _log = Logger(name);
   }
   
   /// Returns the attributes that are registered with the manager.
@@ -47,13 +57,16 @@ abstract class XmppManagerBase {
 
   /// Return a list of features that should be included in a disco response.
   List<String> getDiscoFeatures() => [];
+
+  /// Return a list of identities that should be included in a disco response.
+  List<Identity> getDiscoIdentities() => [];
   
   /// Return the Id (akin to xmlns) of this manager.
-  String getId();
-
-  /// Return a name that will be used for logging.
-  String getName();
+  final String id;
 
+  /// The name of the manager.
+  String get name => toString();
+  
   /// Return the logger for this manager.
   Logger get logger => _log;
   
@@ -62,6 +75,24 @@ abstract class XmppManagerBase {
 
   /// Returns true if the XEP is supported on the server. If not, returns false
   Future<bool> isSupported();
+
+  /// Called after the registration of all managers against the XmppConnection is done.
+  /// This method is only called once during the entire lifetime of it.
+  @mustCallSuper
+  Future<void> postRegisterCallback() async {
+    initialized = true;
+
+    final disco = getAttributes().getManagerById<DiscoManager>(discoManager);
+    if (disco != null) {
+      if (getDiscoFeatures().isNotEmpty) {
+        disco.addFeatures(getDiscoFeatures());
+      }
+
+      if (getDiscoIdentities().isNotEmpty) {
+        disco.addIdentities(getDiscoIdentities());
+      }
+    }
+  }
   
   /// Runs all NonzaHandlers of this Manager which match the nonza. Resolves to true if
   /// the nonza has been handled by one of the handlers. Resolves to false otherwise.
@@ -79,4 +110,25 @@ abstract class XmppManagerBase {
 
     return handled;
   }
+
+  /// Sends a reply of the stanza in [data] with [type]. Replaces the original stanza's
+  /// children with [children].
+  ///
+  /// Note that this function currently only accepts IQ stanzas.
+  Future<void> reply(StanzaHandlerData data, String type, List<XMLNode> children) async {
+    assert(data.stanza.tag == 'iq', 'Reply makes little sense for non-IQ stanzas');
+
+    final stanza = data.stanza.copyWith(
+      to: data.stanza.from,
+      from: data.stanza.to,
+      type: type,
+      children: children,
+    );
+
+    await getAttributes().sendStanza(
+      stanza,
+      awaitable: false,
+      forceEncryption: data.encrypted,
+    );
+  }
 }

packages/moxxmpp/lib/src/managers/data.dart

@@ -50,6 +50,11 @@ class StanzaHandlerData with _$StanzaHandlerData {
       String? funCancellation,
       // Whether the stanza was received encrypted
       @Default(false) bool encrypted,
+      // If true, forces the encryption manager to encrypt to the JID, even if it
+      // would not normally. In the case of OMEMO: If shouldEncrypt returns false
+      // but forceEncryption is true, then the OMEMO manager will try to encrypt
+      // to the JID anyway.
+      @Default(false) bool forceEncryption,
       // The stated type of encryption used, if any was used
       ExplicitEncryptionType? encryptionType,
       // Delayed Delivery

packages/moxxmpp/lib/src/managers/data.freezed.dart

@@ -48,6 +48,11 @@ mixin _$StanzaHandlerData {
   String? get funCancellation =>
       throw _privateConstructorUsedError; // Whether the stanza was received encrypted
   bool get encrypted =>
+      throw _privateConstructorUsedError; // If true, forces the encryption manager to encrypt to the JID, even if it
+// would not normally. In the case of OMEMO: If shouldEncrypt returns false
+// but forceEncryption is true, then the OMEMO manager will try to encrypt
+// to the JID anyway.
+  bool get forceEncryption =>
       throw _privateConstructorUsedError; // The stated type of encryption used, if any was used
   ExplicitEncryptionType? get encryptionType =>
       throw _privateConstructorUsedError; // Delayed Delivery
@@ -94,6 +99,7 @@ abstract class $StanzaHandlerDataCopyWith<$Res> {
       String? funReplacement,
       String? funCancellation,
       bool encrypted,
+      bool forceEncryption,
       ExplicitEncryptionType? encryptionType,
       DelayedDelivery? delayedDelivery,
       Map<String, dynamic> other,
@@ -132,6 +138,7 @@ class _$StanzaHandlerDataCopyWithImpl<$Res>
     Object? funReplacement = freezed,
     Object? funCancellation = freezed,
     Object? encrypted = freezed,
+    Object? forceEncryption = freezed,
     Object? encryptionType = freezed,
     Object? delayedDelivery = freezed,
     Object? other = freezed,
@@ -213,6 +220,10 @@ class _$StanzaHandlerDataCopyWithImpl<$Res>
           ? _value.encrypted
           : encrypted // ignore: cast_nullable_to_non_nullable
               as bool,
+      forceEncryption: forceEncryption == freezed
+          ? _value.forceEncryption
+          : forceEncryption // ignore: cast_nullable_to_non_nullable
+              as bool,
       encryptionType: encryptionType == freezed
           ? _value.encryptionType
           : encryptionType // ignore: cast_nullable_to_non_nullable
@@ -271,6 +282,7 @@ abstract class _$$_StanzaHandlerDataCopyWith<$Res>
       String? funReplacement,
       String? funCancellation,
       bool encrypted,
+      bool forceEncryption,
       ExplicitEncryptionType? encryptionType,
       DelayedDelivery? delayedDelivery,
       Map<String, dynamic> other,
@@ -311,6 +323,7 @@ class __$$_StanzaHandlerDataCopyWithImpl<$Res>
     Object? funReplacement = freezed,
     Object? funCancellation = freezed,
     Object? encrypted = freezed,
+    Object? forceEncryption = freezed,
     Object? encryptionType = freezed,
     Object? delayedDelivery = freezed,
     Object? other = freezed,
@@ -392,6 +405,10 @@ class __$$_StanzaHandlerDataCopyWithImpl<$Res>
           ? _value.encrypted
           : encrypted // ignore: cast_nullable_to_non_nullable
               as bool,
+      forceEncryption: forceEncryption == freezed
+          ? _value.forceEncryption
+          : forceEncryption // ignore: cast_nullable_to_non_nullable
+              as bool,
       encryptionType: encryptionType == freezed
           ? _value.encryptionType
           : encryptionType // ignore: cast_nullable_to_non_nullable
@@ -442,6 +459,7 @@ class _$_StanzaHandlerData implements _StanzaHandlerData {
       this.funReplacement,
       this.funCancellation,
       this.encrypted = false,
+      this.forceEncryption = false,
       this.encryptionType,
       this.delayedDelivery,
       final Map<String, dynamic> other = const <String, dynamic>{},
@@ -506,6 +524,13 @@ class _$_StanzaHandlerData implements _StanzaHandlerData {
   @override
   @JsonKey()
   final bool encrypted;
+// If true, forces the encryption manager to encrypt to the JID, even if it
+// would not normally. In the case of OMEMO: If shouldEncrypt returns false
+// but forceEncryption is true, then the OMEMO manager will try to encrypt
+// to the JID anyway.
+  @override
+  @JsonKey()
+  final bool forceEncryption;
 // The stated type of encryption used, if any was used
   @override
   final ExplicitEncryptionType? encryptionType;
@@ -540,7 +565,7 @@ class _$_StanzaHandlerData implements _StanzaHandlerData {
 
   @override
   String toString() {
-    return 'StanzaHandlerData(done: $done, cancel: $cancel, cancelReason: $cancelReason, stanza: $stanza, retransmitted: $retransmitted, sims: $sims, sfs: $sfs, oob: $oob, stableId: $stableId, reply: $reply, chatState: $chatState, isCarbon: $isCarbon, deliveryReceiptRequested: $deliveryReceiptRequested, isMarkable: $isMarkable, fun: $fun, funReplacement: $funReplacement, funCancellation: $funCancellation, encrypted: $encrypted, encryptionType: $encryptionType, delayedDelivery: $delayedDelivery, other: $other, messageRetraction: $messageRetraction, lastMessageCorrectionSid: $lastMessageCorrectionSid, messageReactions: $messageReactions, stickerPackId: $stickerPackId)';
+    return 'StanzaHandlerData(done: $done, cancel: $cancel, cancelReason: $cancelReason, stanza: $stanza, retransmitted: $retransmitted, sims: $sims, sfs: $sfs, oob: $oob, stableId: $stableId, reply: $reply, chatState: $chatState, isCarbon: $isCarbon, deliveryReceiptRequested: $deliveryReceiptRequested, isMarkable: $isMarkable, fun: $fun, funReplacement: $funReplacement, funCancellation: $funCancellation, encrypted: $encrypted, forceEncryption: $forceEncryption, encryptionType: $encryptionType, delayedDelivery: $delayedDelivery, other: $other, messageRetraction: $messageRetraction, lastMessageCorrectionSid: $lastMessageCorrectionSid, messageReactions: $messageReactions, stickerPackId: $stickerPackId)';
   }
 
   @override
@@ -572,6 +597,8 @@ class _$_StanzaHandlerData implements _StanzaHandlerData {
             const DeepCollectionEquality()
                 .equals(other.funCancellation, funCancellation) &&
             const DeepCollectionEquality().equals(other.encrypted, encrypted) &&
+            const DeepCollectionEquality()
+                .equals(other.forceEncryption, forceEncryption) &&
             const DeepCollectionEquality()
                 .equals(other.encryptionType, encryptionType) &&
             const DeepCollectionEquality()
@@ -608,6 +635,7 @@ class _$_StanzaHandlerData implements _StanzaHandlerData {
         const DeepCollectionEquality().hash(funReplacement),
         const DeepCollectionEquality().hash(funCancellation),
         const DeepCollectionEquality().hash(encrypted),
+        const DeepCollectionEquality().hash(forceEncryption),
         const DeepCollectionEquality().hash(encryptionType),
         const DeepCollectionEquality().hash(delayedDelivery),
         const DeepCollectionEquality().hash(_other),
@@ -641,6 +669,7 @@ abstract class _StanzaHandlerData implements StanzaHandlerData {
       final String? funReplacement,
       final String? funCancellation,
       final bool encrypted,
+      final bool forceEncryption,
       final ExplicitEncryptionType? encryptionType,
       final DelayedDelivery? delayedDelivery,
       final Map<String, dynamic> other,
@@ -690,6 +719,11 @@ abstract class _StanzaHandlerData implements StanzaHandlerData {
   String? get funCancellation;
   @override // Whether the stanza was received encrypted
   bool get encrypted;
+  @override // If true, forces the encryption manager to encrypt to the JID, even if it
+// would not normally. In the case of OMEMO: If shouldEncrypt returns false
+// but forceEncryption is true, then the OMEMO manager will try to encrypt
+// to the JID anyway.
+  bool get forceEncryption;
   @override // The stated type of encryption used, if any was used
   ExplicitEncryptionType? get encryptionType;
   @override // Delayed Delivery

packages/moxxmpp/lib/src/managers/namespaces.dart

@@ -1,25 +1,25 @@
-const smManager = 'im.moxxmpp.streammangementmanager';
-const discoManager = 'im.moxxmpp.discomanager';
-const messageManager = 'im.moxxmpp.messagemanager';
-const rosterManager = 'im.moxxmpp.rostermanager';
-const presenceManager = 'im.moxxmpp.presencemanager';
-const csiManager = 'im.moxxmpp.csimanager';
-const carbonsManager = 'im.moxxmpp.carbonsmanager';
-const vcardManager = 'im.moxxmpp.vcardmanager';
-const pubsubManager = 'im.moxxmpp.pubsubmanager';
-const userAvatarManager = 'im.moxxmpp.useravatarmanager';
-const stableIdManager = 'im.moxxmpp.stableidmanager';
-const simsManager = 'im.moxxmpp.simsmanager';
-const messageDeliveryReceiptManager = 'im.moxxmpp.messagedeliveryreceiptmanager';
-const chatMarkerManager = 'im.moxxmpp.chatmarkermanager';
-const oobManager = 'im.moxxmpp.oobmanager';
-const sfsManager = 'im.moxxmpp.sfsmanager';
-const messageRepliesManager = 'im.moxxmpp.messagerepliesmanager';
-const blockingManager = 'im.moxxmpp.blockingmanager';
-const httpFileUploadManager = 'im.moxxmpp.httpfileuploadmanager';
-const chatStateManager = 'im.moxxmpp.chatstatemanager';
-const pingManager = 'im.moxxmpp.ping';
-const fileUploadNotificationManager = 'im.moxxmpp.fileuploadnotificationmanager';
+const smManager = 'org.moxxmpp.streammangementmanager';
+const discoManager = 'org.moxxmpp.discomanager';
+const messageManager = 'org.moxxmpp.messagemanager';
+const rosterManager = 'org.moxxmpp.rostermanager';
+const presenceManager = 'org.moxxmpp.presencemanager';
+const csiManager = 'org.moxxmpp.csimanager';
+const carbonsManager = 'org.moxxmpp.carbonsmanager';
+const vcardManager = 'org.moxxmpp.vcardmanager';
+const pubsubManager = 'org.moxxmpp.pubsubmanager';
+const userAvatarManager = 'org.moxxmpp.useravatarmanager';
+const stableIdManager = 'org.moxxmpp.stableidmanager';
+const simsManager = 'org.moxxmpp.simsmanager';
+const messageDeliveryReceiptManager = 'org.moxxmpp.messagedeliveryreceiptmanager';
+const chatMarkerManager = 'org.moxxmpp.chatmarkermanager';
+const oobManager = 'org.moxxmpp.oobmanager';
+const sfsManager = 'org.moxxmpp.sfsmanager';
+const messageRepliesManager = 'org.moxxmpp.messagerepliesmanager';
+const blockingManager = 'org.moxxmpp.blockingmanager';
+const httpFileUploadManager = 'org.moxxmpp.httpfileuploadmanager';
+const chatStateManager = 'org.moxxmpp.chatstatemanager';
+const pingManager = 'org.moxxmpp.ping';
+const fileUploadNotificationManager = 'org.moxxmpp.fileuploadnotificationmanager';
 const omemoManager = 'org.moxxmpp.omemomanager';
 const emeManager = 'org.moxxmpp.ememanager';
 const cryptographicHashManager = 'org.moxxmpp.cryptographichashmanager';
@@ -28,3 +28,4 @@ const messageRetractionManager = 'org.moxxmpp.messageretractionmanager';
 const lastMessageCorrectionManager = 'org.moxxmpp.lastmessagecorrectionmanager';
 const messageReactionsManager = 'org.moxxmpp.messagereactionsmanager';
 const stickersManager = 'org.moxxmpp.stickersmanager';
+const entityCapabilitiesManager = 'org.moxxmpp.entitycapabilities';

packages/moxxmpp/lib/src/message.dart

@@ -76,11 +76,7 @@ class MessageDetails {
 }
 
 class MessageManager extends XmppManagerBase {
-  @override
-  String getId() => messageManager;
-
-  @override
-  String getName() => 'MessageManager';
+  MessageManager() : super(messageManager);
 
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [

packages/moxxmpp/lib/src/ping.dart

@@ -4,11 +4,7 @@ import 'package:moxxmpp/src/managers/namespaces.dart';
 import 'package:moxxmpp/src/xeps/xep_0198/xep_0198.dart';
 
 class PingManager extends XmppManagerBase {
-  @override
-  String getId() => pingManager;
-
-  @override
-  String getName() => 'PingManager';
+  PingManager() : super(pingManager);
 
   @override
   Future<bool> isSupported() async => true;

packages/moxxmpp/lib/src/presence.dart

@@ -8,23 +8,19 @@ import 'package:moxxmpp/src/managers/namespaces.dart';
 import 'package:moxxmpp/src/namespaces.dart';
 import 'package:moxxmpp/src/stanza.dart';
 import 'package:moxxmpp/src/stringxml.dart';
-import 'package:moxxmpp/src/xeps/xep_0030/types.dart';
-import 'package:moxxmpp/src/xeps/xep_0030/xep_0030.dart';
-import 'package:moxxmpp/src/xeps/xep_0115.dart';
-import 'package:moxxmpp/src/xeps/xep_0414.dart';
 
+/// A function that will be called when presence, outside of subscription request
+/// management, will be sent. Useful for managers that want to add [XMLNode]s to said
+/// presence.
+typedef PresencePreSendCallback = Future<List<XMLNode>> Function();
+
+/// A mandatory manager that handles initial presence sending, sending of subscription
+/// request management requests and triggers events for incoming presence stanzas.
 class PresenceManager extends XmppManagerBase {
-  PresenceManager(this._capHashNode) : _capabilityHash = null, super();
-  String? _capabilityHash;
-  final String _capHashNode;
+  PresenceManager() : super(presenceManager);
 
-  String get capabilityHashNode => _capHashNode;
-  
-  @override
-  String getId() => presenceManager;
-
-  @override
-  String getName() => 'PresenceManager';
+  /// The list of pre-send callbacks.
+  final List<PresencePreSendCallback> _presenceCallbacks = List.empty(growable: true);
 
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [
@@ -39,6 +35,11 @@ class PresenceManager extends XmppManagerBase {
 
   @override
   Future<bool> isSupported() async => true;
+
+  /// Register the pre-send callback [callback].
+  void registerPreSendCallback(PresencePreSendCallback callback) {
+    _presenceCallbacks.add(callback);
+  }
   
   Future<StanzaHandlerData> _onPresence(Stanza presence, StanzaHandlerData state) async {
     final attrs = getAttributes();
@@ -63,43 +64,26 @@ class PresenceManager extends XmppManagerBase {
     return state;
   }
 
-  /// Returns the capability hash.
-  Future<String> getCapabilityHash() async {
-    final manager = getAttributes().getManagerById(discoManager)! as DiscoManager;
-    _capabilityHash ??= await calculateCapabilityHash(
-      DiscoInfo(
-        manager.getRegisteredDiscoFeatures(),
-        manager.getIdentities(),
-        [],
-        getAttributes().getFullJID(),
-      ),
-      getHashByName('sha-1')!,
-    );
-
-    return _capabilityHash!;
-  }
-  
   /// Sends the initial presence to enable receiving messages.
   Future<void> sendInitialPresence() async {
+    final children = List<XMLNode>.from([
+      XMLNode(
+        tag: 'show',
+        text: 'chat',
+      ),
+    ]);
+
+    for (final callback in _presenceCallbacks) {
+      children.addAll(
+        await callback(),
+      );
+    }
+
     final attrs = getAttributes();
     attrs.sendNonza(
       Stanza.presence(
         from: attrs.getFullJID().toString(),
-        children: [
-          XMLNode(
-            tag: 'show',
-            text: 'chat',
-          ),
-          XMLNode.xmlns(
-            tag: 'c',
-            xmlns: capsXmlns,
-            attributes: {
-              'hash': 'sha-1',
-              'node': _capHashNode,
-              'ver': await getCapabilityHash()
-            },
-          )
-        ],
+        children: children,
       ),
     );
   }

packages/moxxmpp/lib/src/reconnect.dart

@@ -2,6 +2,7 @@ import 'dart:async';
 import 'dart:math';
 import 'package:logging/logging.dart';
 import 'package:meta/meta.dart';
+import 'package:moxxmpp/src/util/queue.dart';
 import 'package:synchronized/synchronized.dart';
 
 /// A callback function to be called when the connection to the server has been lost.
@@ -24,10 +25,16 @@ abstract class ReconnectionPolicy {
   bool _shouldAttemptReconnection = false;
 
   /// Indicate if a reconnection attempt is currently running.
-  bool _isReconnecting = false;
+  @protected
+  bool isReconnecting = false;
 
   /// And the corresponding lock
-  final Lock _isReconnectingLock = Lock();
+  @protected
+  final Lock lock = Lock();
+
+  /// The lock for accessing [_shouldAttemptReconnection]
+  @protected
+  final Lock shouldReconnectLock = Lock();
   
   /// Called by XmppConnection to register the policy.
   void register(PerformReconnectFunction performReconnect, ConnectionLostCallback triggerConnectionLost) {
@@ -48,92 +55,122 @@ abstract class ReconnectionPolicy {
   /// Caled by the XmppConnection when the reconnection was successful.
   Future<void> onSuccess();
 
-  bool get shouldReconnect => _shouldAttemptReconnection;
+  Future<bool> getShouldReconnect() async {
+    return shouldReconnectLock.synchronized(() => _shouldAttemptReconnection);
+  }
 
   /// Set whether a reconnection attempt should be made.
-  void setShouldReconnect(bool value) {
-    _shouldAttemptReconnection = value;
+  Future<void> setShouldReconnect(bool value) async {
+    return shouldReconnectLock.synchronized(() => _shouldAttemptReconnection = value);
   }
 
   /// Returns true if the manager is currently triggering a reconnection. If not, returns
   /// false.
   Future<bool> isReconnectionRunning() async {
-    return _isReconnectingLock.synchronized(() => _isReconnecting);
+    return lock.synchronized(() => isReconnecting);
   }
 
-  /// Set the _isReconnecting state to [value].
+  /// Set the isReconnecting state to [value].
   @protected
   Future<void> setIsReconnecting(bool value) async {
-    await _isReconnectingLock.synchronized(() async {
-      _isReconnecting = value;
+    await lock.synchronized(() async {
+      isReconnecting = value;
     });
   }
 
-  @protected
-  Future<bool> testAndSetIsReconnecting() async {
-    return _isReconnectingLock.synchronized(() {
-      if (_isReconnecting) {
-        return false;
-      } else {
-        _isReconnecting = true;
-        return true;
-      }
-    });
-  }
 }
 
 /// A simple reconnection strategy: Make the reconnection delays exponentially longer
 /// for every failed attempt.
-class ExponentialBackoffReconnectionPolicy extends ReconnectionPolicy {
+/// NOTE: This ReconnectionPolicy may be broken
+class RandomBackoffReconnectionPolicy extends ReconnectionPolicy {
+  RandomBackoffReconnectionPolicy(
+    this._minBackoffTime,
+    this._maxBackoffTime,
+  ) : assert(_minBackoffTime < _maxBackoffTime, '_minBackoffTime must be smaller than _maxBackoffTime'),
+      super();
 
-  ExponentialBackoffReconnectionPolicy(this._maxBackoffTime)
-  : _counter = 0,
-    _log = Logger('ExponentialBackoffReconnectionPolicy'),
-    super();
+  /// The maximum time in seconds that a backoff should be.
   final int _maxBackoffTime;
-  int _counter;
+
+  /// The minimum time in seconds that a backoff should be.
+  final int _minBackoffTime;
+
+  /// Backoff timer.
   Timer? _timer;
-  final Logger _log;
+
+  final Lock _timerLock = Lock();
+
+  /// Logger.
+  final Logger _log = Logger('RandomBackoffReconnectionPolicy');
+
+  /// Event queue
+  final AsyncQueue _eventQueue = AsyncQueue();
 
   /// Called when the backoff expired
   Future<void> _onTimerElapsed() async {
-    final isReconnecting = await isReconnectionRunning();
-    if (shouldReconnect) {
-      if (!isReconnecting) {
-        await setIsReconnecting(true);
-        await performReconnect!();
-      } else {
-        // Should never happen.
-        _log.fine('Backoff timer expired but reconnection is running, so doing nothing.');
+    _log.fine('Timer elapsed. Waiting for lock');
+    await lock.synchronized(() async {
+      _log.fine('Lock aquired');
+      if (!(await getShouldReconnect())) {
+        _log.fine('Backoff timer expired but getShouldReconnect() returned false');
+        return;
       }
-    }
+
+      if (isReconnecting) {
+        _log.fine('Backoff timer expired but a reconnection is running, so doing nothing.');
+        return;
+      }
+
+      _log.fine('Triggering reconnect');
+      isReconnecting = true;
+      await performReconnect!();
+    });
+
+    await _timerLock.synchronized(() {
+      _timer?.cancel();
+      _timer = null;
+    });
+  }
+
+  Future<void> _reset() async {
+    _log.finest('Resetting internal state');
+
+    await _timerLock.synchronized(() {
+      _timer?.cancel();
+      _timer = null;
+    });
+
+    await setIsReconnecting(false);
   }
   
   @override
   Future<void> reset() async {
-    _log.finest('Resetting internal state');
-    _counter = 0;
-    await setIsReconnecting(false);
-
-    if (_timer != null) {
-      _timer!.cancel();
-      _timer = null;
-    }
+    // ignore: unnecessary_lambdas
+    await _eventQueue.addJob(() => _reset());
   }
 
-  @override
-  Future<void> onFailure() async {
-    _log.finest('Failure occured. Starting exponential backoff');
-    _counter++;
-
-    if (_timer != null) {
-      _timer!.cancel();
+  Future<void> _onFailure() async {
+    final shouldContinue = await _timerLock.synchronized(() {
+      return _timer == null;
+    });
+    if (!shouldContinue) {
+      _log.finest('_onFailure: Not backing off since _timer is already running');
+      return;
     }
 
-    // Wait at max 80 seconds.
-    final seconds = min(min(pow(2, _counter).toInt(), 80), _maxBackoffTime);
+    final seconds = Random().nextInt(_maxBackoffTime - _minBackoffTime) + _minBackoffTime;
+    _log.finest('Failure occured. Starting random backoff with ${seconds}s');
+    _timer?.cancel();
+
     _timer = Timer(Duration(seconds: seconds), _onTimerElapsed);
   }
+  
+  @override
+  Future<void> onFailure() async {
+    // ignore: unnecessary_lambdas
+    await _eventQueue.addJob(() => _onFailure());
+  }
 
   @override
   Future<void> onSuccess() async {
@@ -141,7 +178,7 @@ class ExponentialBackoffReconnectionPolicy extends ReconnectionPolicy {
   }
 }
 
-/// A stub reconnection policy for tests
+/// A stub reconnection policy for tests.
 @visibleForTesting
 class TestingReconnectionPolicy extends ReconnectionPolicy {
   TestingReconnectionPolicy() : super();

packages/moxxmpp/lib/src/roster/roster.dart

@@ -93,7 +93,7 @@ class RosterFeatureNegotiator extends XmppFeatureNegotiatorBase {
 
 /// This manager requires a RosterFeatureNegotiator to be registered.
 class RosterManager extends XmppManagerBase {
-  RosterManager(this._stateManager) : super();
+  RosterManager(this._stateManager) : super(rosterManager);
 
   /// The class managing the entire roster state.
   final BaseRosterStateManager _stateManager;
@@ -104,12 +104,6 @@ class RosterManager extends XmppManagerBase {
     _stateManager.register(attributes.sendEvent); 
   }
   
-  @override
-  String getId() => rosterManager;
-
-  @override
-  String getName() => 'RosterManager';
-
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [
     StanzaHandler(
@@ -161,7 +155,11 @@ class RosterManager extends XmppManagerBase {
       ),
     );
     
-    await attrs.sendStanza(stanza.reply());
+    await reply(
+      state,
+      'result',
+      [],
+    );
 
     return state.copyWith(done: true);
   }

packages/moxxmpp/lib/src/stanza.dart

@@ -114,40 +114,27 @@ class Stanza extends XMLNode {
       children: children ?? this.children,
     );
   }
-  
-  Stanza reply({ List<XMLNode> children = const [] }) {
-    return copyWith(
-      from: attributes['to'] as String?,
-      to: attributes['from'] as String?,
-      type: tag == 'iq' ? 'result' : attributes['type'] as String?,
-      children: children,
-    );
-  }
-
-  Stanza errorReply(String type, String condition, { String? text }) {
-   return copyWith(
-      from: attributes['to'] as String?,
-      to: attributes['from'] as String?,
-      type: 'error',
-      children: [
-        XMLNode(
-          tag: 'error',
-          attributes: <String, dynamic>{ 'type': type },
-          children: [
-            XMLNode.xmlns(
-              tag: condition,
-              xmlns: fullStanzaXmlns,
-              children: text != null ?[
-                XMLNode.xmlns(
-                  tag: 'text',
-                  xmlns: fullStanzaXmlns,
-                  text: text,
-                )
-              ] : [],
-            )
-          ],
-        )
-      ],
-    );
-  }
+}
+
+/// Build an <error /> element with a child <[condition] type="[type]" />. If [text]
+/// is not null, then the condition element will contain a <text /> element with [text]
+/// as the body.
+XMLNode buildErrorElement(String type, String condition, { String? text }) {
+  return XMLNode(
+    tag: 'error',
+    attributes: <String, dynamic>{ 'type': type },
+    children: [
+      XMLNode.xmlns(
+        tag: condition,
+        xmlns: fullStanzaXmlns,
+        children: text != null ? [
+          XMLNode.xmlns(
+            tag: 'text',
+            xmlns: fullStanzaXmlns,
+            text: text,
+          )
+        ] : [],
+      ),
+    ],
+  );
 }

packages/moxxmpp/lib/src/stringxml.dart

@@ -1,7 +1,6 @@
 import 'package:xml/xml.dart';
 
 class XMLNode {
-
   XMLNode({
     required this.tag,
     this.attributes = const <String, dynamic>{},

packages/moxxmpp/lib/src/util/queue.dart

@@ -0,0 +1,56 @@
+import 'dart:async';
+import 'dart:collection';
+import 'package:meta/meta.dart';
+import 'package:synchronized/synchronized.dart';
+
+/// A job to be submitted to an [AsyncQueue].
+typedef AsyncQueueJob = Future<void> Function();
+
+/// A (hopefully) async-safe queue that attempts to force
+/// in-order execution of its jobs.
+class AsyncQueue {
+  /// The lock for accessing [AsyncQueue._lock] and [AsyncQueue._running].
+  final Lock _lock = Lock();
+
+  /// The actual job queue.
+  final Queue<AsyncQueueJob> _queue = Queue<AsyncQueueJob>();
+  
+  /// Indicates whether we are currently executing a job.
+  bool _running = false;
+
+  @visibleForTesting
+  Queue<AsyncQueueJob> get queue => _queue;
+
+  @visibleForTesting
+  bool get isRunning => _running;
+  
+  /// Adds a job [job] to the queue.
+  Future<void> addJob(AsyncQueueJob job) async {
+    await _lock.synchronized(() {
+      _queue.add(job);
+
+      if (!_running && _queue.isNotEmpty) {
+        _running = true;
+        unawaited(_popJob());
+      }
+    });
+  }
+
+  Future<void> clear() async {
+    await _lock.synchronized(_queue.clear);
+  }
+  
+  Future<void> _popJob() async {
+    final job = _queue.removeFirst();
+    final future = job();
+    await future;
+
+    await _lock.synchronized(() {
+      if (_queue.isNotEmpty) {
+        unawaited(_popJob());
+      } else {
+        _running = false;
+      }
+    });
+  }
+}

packages/moxxmpp/lib/src/util/wait.dart

@@ -0,0 +1,67 @@
+import 'dart:async';
+import 'package:meta/meta.dart';
+import 'package:synchronized/synchronized.dart';
+
+/// This class allows for multiple asynchronous code places to wait on the
+/// same computation of type [V], indentified by a key of type [K].
+class WaitForTracker<K, V> {
+  /// The mapping of key -> Completer for the pending tasks.
+  final Map<K, List<Completer<V>>> _tracker = {};
+
+  /// The lock for accessing _tracker.
+  final Lock _lock = Lock();
+
+  /// Wait for a task with key [key]. If there was no such task already
+  /// present, returns null. If one or more tasks were already present, returns
+  /// a future that will resolve to the result of the first task.
+  Future<Future<V>?> waitFor(K key) async {
+    final result = await _lock.synchronized(() {
+      if (_tracker.containsKey(key)) {
+        // The task already exists. Just append outselves
+        final completer = Completer<V>();
+        _tracker[key]!.add(completer);
+        return completer;
+      }
+
+      // The task does not exist yet
+      _tracker[key] = List<Completer<V>>.empty(growable: true);
+      return null;
+    });
+
+    return result?.future;
+  }
+
+  /// Resolve a task with key [key] to [value].
+  Future<void> resolve(K key, V value) async {
+    await _lock.synchronized(() {
+      if (!_tracker.containsKey(key)) return;
+
+      for (final completer in _tracker[key]!) {
+        completer.complete(value);
+      }
+
+      _tracker.remove(key);
+    });
+  }
+
+  Future<void> resolveAll(V value) async {
+    await _lock.synchronized(() {
+      for (final key in _tracker.keys) {
+        for (final completer in _tracker[key]!) {
+          completer.complete(value);
+        }
+      }
+    });
+  }
+  
+  /// Remove all tasks from the tracker.
+  Future<void> clear() async {
+    await _lock.synchronized(_tracker.clear);
+  }
+
+  @visibleForTesting
+  bool hasTasksRunning() => _tracker.isNotEmpty;
+
+  @visibleForTesting
+  List<Completer<V>> getRunningTasks(K key) => _tracker[key]!;
+}

packages/moxxmpp/lib/src/xeps/staging/file_upload_notification.dart

@@ -11,13 +11,7 @@ import 'package:moxxmpp/src/xeps/xep_0446.dart';
 const fileUploadNotificationXmlns = 'proto:urn:xmpp:fun:0';
 
 class FileUploadNotificationManager extends XmppManagerBase {
-  FileUploadNotificationManager() : super();
-
-  @override
-  String getId() => fileUploadNotificationManager;
-
-  @override
-  String getName() => 'FileUploadNotificationManager';
+  FileUploadNotificationManager() : super(fileUploadNotificationManager);
 
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [

packages/moxxmpp/lib/src/xeps/xep_0004.dart

@@ -3,7 +3,6 @@ import 'package:moxxmpp/src/namespaces.dart';
 import 'package:moxxmpp/src/stringxml.dart';
 
 class DataFormOption {
-
   const DataFormOption({ required this.value, this.label });
   final String? label;
   final String value;
@@ -23,7 +22,6 @@ class DataFormOption {
 }
 
 class DataFormField {
-
   const DataFormField({
       required this.options,
       required this.values,
@@ -60,7 +58,6 @@ class DataFormField {
 }
 
 class DataForm {
-
   const DataForm({
       required this.type,
       required this.instructions,

packages/moxxmpp/lib/src/xeps/xep_0030/cache.dart

@@ -0,0 +1,23 @@
+import 'package:meta/meta.dart';
+
+@internal
+@immutable
+class DiscoCacheKey {
+  const DiscoCacheKey(this.jid, this.node);
+  
+  /// The JID we're requesting disco data from.
+  final String jid;
+
+  /// Optionally the node we are requesting from.
+  final String? node;
+
+  @override
+  bool operator ==(Object other) {
+    return other is DiscoCacheKey &&
+           jid == other.jid &&
+           node == other.node;
+  }
+  
+  @override
+  int get hashCode => jid.hashCode ^ node.hashCode;
+}

packages/moxxmpp/lib/src/xeps/xep_0030/helpers.dart

@@ -6,20 +6,20 @@ import 'package:moxxmpp/src/stringxml.dart';
 
 Stanza buildDiscoInfoQueryStanza(String entity, String? node) {
   return Stanza.iq(to: entity, type: 'get', children: [
-      XMLNode.xmlns(
-        tag: 'query',
-        xmlns: discoInfoXmlns,
-        attributes: node != null ? { 'node': node } : {},
-      )
+    XMLNode.xmlns(
+      tag: 'query',
+      xmlns: discoInfoXmlns,
+      attributes: node != null ? { 'node': node } : {},
+    )
   ],);
 }
 
 Stanza buildDiscoItemsQueryStanza(String entity, { String? node }) {
   return Stanza.iq(to: entity, type: 'get', children: [
-      XMLNode.xmlns(
-        tag: 'query',
-        xmlns: discoItemsXmlns,
-        attributes: node != null ? { 'node': node } : {},
-      )
+    XMLNode.xmlns(
+      tag: 'query',
+      xmlns: discoItemsXmlns,
+      attributes: node != null ? { 'node': node } : {},
+    )
   ],);
 }

packages/moxxmpp/lib/src/xeps/xep_0030/types.dart

@@ -1,9 +1,10 @@
+import 'package:meta/meta.dart';
 import 'package:moxxmpp/src/jid.dart';
+import 'package:moxxmpp/src/namespaces.dart';
 import 'package:moxxmpp/src/stringxml.dart';
 import 'package:moxxmpp/src/xeps/xep_0004.dart';
 
 class Identity {
-
   const Identity({ required this.category, required this.type, this.name, this.lang });
   final String category;
   final String type;
@@ -23,24 +24,96 @@ class Identity {
   }
 }
 
+@immutable
 class DiscoInfo {
-
   const DiscoInfo(
     this.features,
     this.identities,
     this.extendedInfo,
+    this.node,
     this.jid,
   );
+
+  factory DiscoInfo.fromQuery(XMLNode query, JID jid) {
+    final features = List<String>.empty(growable: true);
+    final identities = List<Identity>.empty(growable: true);
+    final extendedInfo = List<DataForm>.empty(growable: true);
+
+    for (final element in query.children) {
+      if (element.tag == 'feature') {
+        features.add(element.attributes['var']! as String);
+      } else if (element.tag == 'identity') {
+        identities.add(
+          Identity(
+            category: element.attributes['category']! as String,
+            type: element.attributes['type']! as String,
+            name: element.attributes['name'] as String?,
+          ),
+        );
+      } else if (element.tag == 'x' && element.attributes['xmlns'] == dataFormsXmlns) {
+        extendedInfo.add(
+          parseDataForm(element),
+        );
+      }
+    }
+
+    return DiscoInfo(
+      features,
+      identities,
+      extendedInfo,
+      query.attributes['node'] as String?,
+      jid,
+    );
+  }
+
   final List<String> features;
   final List<Identity> identities;
   final List<DataForm> extendedInfo;
-  final JID jid;
+  final String? node;
+  final JID? jid;
+
+  XMLNode toXml() {
+    return XMLNode.xmlns(
+      tag: 'query',
+      xmlns: discoInfoXmlns,
+      attributes: node != null ?
+        <String, String>{ 'node': node!, } :
+        <String, String>{},
+      children: [
+        ...identities.map((identity) => identity.toXMLNode()),
+        ...features.map((feature) => XMLNode(
+          tag: 'feature',
+          attributes: { 'var': feature, },
+        ),),
+        
+        if (extendedInfo.isNotEmpty)
+          ...extendedInfo.map((ei) => ei.toXml()),
+      ],
+    );
+  }
 }
 
+@immutable
 class DiscoItem {
-
   const DiscoItem({ required this.jid, this.node, this.name });
   final String jid;
   final String? node;
   final String? name;
+
+  XMLNode toXml() {
+    final attributes = {
+      'jid': jid,
+    };
+    if (node != null) {
+      attributes['node'] = node!;
+    }
+    if (name != null) {
+      attributes['name'] = name!;
+    }
+
+    return XMLNode(
+      tag: 'node',
+      attributes: attributes,
+    );
+  }
 }

packages/moxxmpp/lib/src/xeps/xep_0030/xep_0030.dart

@@ -1,5 +1,6 @@
 import 'dart:async';
 import 'package:meta/meta.dart';
+import 'package:moxxmpp/src/connection.dart';
 import 'package:moxxmpp/src/events.dart';
 import 'package:moxxmpp/src/jid.dart';
 import 'package:moxxmpp/src/managers/base.dart';
@@ -7,62 +8,71 @@ import 'package:moxxmpp/src/managers/data.dart';
 import 'package:moxxmpp/src/managers/handlers.dart';
 import 'package:moxxmpp/src/managers/namespaces.dart';
 import 'package:moxxmpp/src/namespaces.dart';
-import 'package:moxxmpp/src/presence.dart';
 import 'package:moxxmpp/src/stanza.dart';
 import 'package:moxxmpp/src/stringxml.dart';
 import 'package:moxxmpp/src/types/result.dart';
-import 'package:moxxmpp/src/xeps/xep_0004.dart';
+import 'package:moxxmpp/src/util/wait.dart';
+import 'package:moxxmpp/src/xeps/xep_0030/cache.dart';
 import 'package:moxxmpp/src/xeps/xep_0030/errors.dart';
 import 'package:moxxmpp/src/xeps/xep_0030/helpers.dart';
 import 'package:moxxmpp/src/xeps/xep_0030/types.dart';
 import 'package:moxxmpp/src/xeps/xep_0115.dart';
 import 'package:synchronized/synchronized.dart';
 
-@immutable
-class DiscoCacheKey {
+/// Callback that is called when a disco#info requests is received on a given node.
+typedef DiscoInfoRequestCallback = Future<DiscoInfo> Function();
 
-  const DiscoCacheKey(this.jid, this.node);
-  final String jid;
-  final String? node;
-
-  @override
-  bool operator ==(Object other) {
-    return other is DiscoCacheKey && jid == other.jid && node == other.node;
-  }
-  
-  @override
-  int get hashCode => jid.hashCode ^ node.hashCode;
-}
+/// Callback that is called when a disco#items requests is received on a given node.
+typedef DiscoItemsRequestCallback = Future<List<DiscoItem>> Function();
 
+/// This manager implements XEP-0030 by providing a way of performing disco#info and
+/// disco#items requests and answering those requests.
+/// A caching mechanism is also provided.
 class DiscoManager extends XmppManagerBase {
- 
-  DiscoManager()
-    : _features = List.empty(growable: true),
-      _capHashCache = {},
-      _capHashInfoCache = {},
-      _discoInfoCache = {},
-      _runningInfoQueries = {},
-      _cacheLock = Lock(),
-      super();
+  /// [identities] is a list of disco identities that should be added by default
+  /// to a disco#info response.
+  DiscoManager(List<Identity> identities)
+    : _identities = List<Identity>.from(identities),
+      super(discoManager);
+
   /// Our features
-  final List<String> _features;
+  final List<String> _features = List.empty(growable: true);
 
-  // Map full JID to Capability hashes
-  final Map<String, CapabilityHashInfo> _capHashCache;
-  // Map capability hash to the disco info
-  final Map<String, DiscoInfo> _capHashInfoCache;
-  // Map full JID to Disco Info
-  final Map<DiscoCacheKey, DiscoInfo> _discoInfoCache;
-  // Mapping the full JID to a list of running requests
-  final Map<DiscoCacheKey, List<Completer<Result<DiscoError, DiscoInfo>>>> _runningInfoQueries;
-  // Cache lock
-  final Lock _cacheLock;
+  /// Disco identities that we advertise
+  final List<Identity> _identities;
+  
+  /// Map full JID to Capability hashes
+  final Map<String, CapabilityHashInfo> _capHashCache = {};
+
+  /// Map capability hash to the disco info
+  final Map<String, DiscoInfo> _capHashInfoCache = {};
+
+  /// Map full JID to Disco Info
+  final Map<DiscoCacheKey, DiscoInfo> _discoInfoCache = {};
+
+  /// The tracker for tracking disco#info queries that are in flight.
+  final WaitForTracker<DiscoCacheKey, Result<DiscoError, DiscoInfo>> _discoInfoTracker = WaitForTracker();
+
+  /// The tracker for tracking disco#info queries that are in flight.
+  final WaitForTracker<DiscoCacheKey, Result<DiscoError, List<DiscoItem>>> _discoItemsTracker = WaitForTracker();
+
+  /// Cache lock
+  final Lock _cacheLock = Lock();
+
+  /// disco#info callbacks: node -> Callback
+  final Map<String, DiscoInfoRequestCallback> _discoInfoCallbacks = {};
+
+  /// disco#items callbacks: node -> Callback
+  final Map<String, DiscoItemsRequestCallback> _discoItemsCallbacks = {};
+
+  /// The list of identities that are registered.
+  List<Identity> get identities => _identities;
+
+  /// The list of disco features that are registered.
+  List<String> get features => _features;
 
   @visibleForTesting
-  bool hasInfoQueriesRunning() => _runningInfoQueries.isNotEmpty;
-
-  @visibleForTesting
-  List<Completer<Result<DiscoError, DiscoInfo>>> getRunningInfoQueries(DiscoCacheKey key) => _runningInfoQueries[key]!;
+  WaitForTracker<DiscoCacheKey, Result<DiscoError, DiscoInfo>> get infoTracker => _discoInfoTracker;
   
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [
@@ -80,12 +90,6 @@ class DiscoManager extends XmppManagerBase {
     ),
   ];
 
-  @override
-  String getId() => discoManager;
-
-  @override
-  String getName() => 'DiscoManager';
-
   @override
   List<String> getDiscoFeatures() => [ discoInfoXmlns, discoItemsXmlns ];
 
@@ -96,17 +100,41 @@ class DiscoManager extends XmppManagerBase {
   Future<void> onXmppEvent(XmppEvent event) async {
     if (event is PresenceReceivedEvent) {
       await _onPresence(event.jid, event.presence);
-    } else if (event is StreamResumeFailedEvent) {
+    } else if (event is ConnectionStateChangedEvent) {
+      // TODO(Unknown): This handling is stupid. We should have an event that is
+      //                triggered when we cannot guarantee that everything is as
+      //                it was before.
+      if (event.state != XmppConnectionState.connected) return;
+      if (event.resumed) return;
+
+      // Cancel all waiting requests
+      await _discoInfoTracker.resolveAll(
+        Result<DiscoError, DiscoInfo>(UnknownDiscoError()),
+      );
+      await _discoItemsTracker.resolveAll(
+        Result<DiscoError, List<DiscoItem>>(UnknownDiscoError()),
+      );
+      
       await _cacheLock.synchronized(() async {
         // Clear the cache
         _discoInfoCache.clear();
       });
     }
   }
+
+  /// Register a callback [callback] for a disco#info query on [node].
+  void registerInfoCallback(String node, DiscoInfoRequestCallback callback) {
+    _discoInfoCallbacks[node] = callback;
+  }
+
+  /// Register a callback [callback] for a disco#items query on [node].
+  void registerItemsCallback(String node, DiscoItemsRequestCallback callback) {
+    _discoItemsCallbacks[node] = callback;
+  }
   
   /// Adds a list of features to the possible disco info response.
   /// This function only adds features that are not already present in the disco features.
-  void addDiscoFeatures(List<String> features) {
+  void addFeatures(List<String> features) {
     for (final feat in features) {
       if (!_features.contains(feat)) {
         _features.add(feat);
@@ -114,6 +142,16 @@ class DiscoManager extends XmppManagerBase {
     }
   }
 
+  /// Adds a list of identities to the possible disco info response.
+  /// This function only adds features that are not already present in the disco features.
+  void addIdentities(List<Identity> identities) {
+    for (final identity in identities) {
+      if (!_identities.contains(identity)) {
+        _identities.add(identity);
+      }
+    }
+  }
+  
   Future<void> _onPresence(JID from, Stanza presence) async {
     final c = presence.firstTag('c', xmlns: capsXmlns);
     if (c == null) return;
@@ -144,77 +182,46 @@ class DiscoManager extends XmppManagerBase {
     });
   }
   
-  /// Returns the list of disco features registered.
-  List<String> getRegisteredDiscoFeatures() => _features;
-  
-  /// May be overriden. Specifies the identities which will be returned in a disco info response.
-  List<Identity> getIdentities() => const [ Identity(category: 'client', type: 'pc', name: 'moxxmpp', lang: 'en') ];
+  /// Returns the [DiscoInfo] object that would be used as the response to a disco#info
+  /// query against our bare JID with no node. The results node attribute is set
+  /// to [node].
+  DiscoInfo getDiscoInfo(String? node) {
+    return DiscoInfo(
+      _features,
+      _identities,
+      const [],
+      node,
+      null,
+    );
+  }
   
   Future<StanzaHandlerData> _onDiscoInfoRequest(Stanza stanza, StanzaHandlerData state) async {
     if (stanza.type != 'get') return state;
 
-    final presence = getAttributes().getManagerById(presenceManager)! as PresenceManager;
-    final query = stanza.firstTag('query')!;
+    final query = stanza.firstTag('query', xmlns: discoInfoXmlns)!;
     final node = query.attributes['node'] as String?;
-    final capHash = await presence.getCapabilityHash();
-    final isCapabilityNode = node == '${presence.capabilityHashNode}#$capHash';
 
-    if (!isCapabilityNode && node != null) {
-      await getAttributes().sendStanza(Stanza.iq(
-            to: stanza.from,
-            from: stanza.to,
-            id: stanza.id,
-            type: 'error',
-            children: [
-              XMLNode.xmlns(
-                tag: 'query',
-                // TODO(PapaTutuWawa): Why are we copying the xmlns?
-                xmlns: query.attributes['xmlns']! as String,
-                attributes: <String, String>{
-                  'node': node
-                },
-              ),
-              XMLNode(
-                tag: 'error',
-                attributes: <String, String>{
-                  'type': 'cancel'
-                },
-                children: [
-                  XMLNode.xmlns(
-                    tag: 'not-allowed',
-                    xmlns: fullStanzaXmlns,
-                  )
-                ],
-              )
-            ],
-          )
-      ,);
+    if (_discoInfoCallbacks.containsKey(node)) {
+      // We can now assume that node != null
+      final result = await _discoInfoCallbacks[node]!();
+      await reply(
+        state,
+        'result',
+        [
+          result.toXml(),
+        ],
+      );
 
       return state.copyWith(done: true);
     }
 
-    await getAttributes().sendStanza(stanza.reply(
-        children: [
-          XMLNode.xmlns(
-            tag: 'query',
-            xmlns: discoInfoXmlns,
-            attributes: {
-              ...!isCapabilityNode ? {} : {
-                'node': '${presence.capabilityHashNode}#$capHash'
-              }
-            },
-            children: [
-              ...getIdentities().map((identity) => identity.toXMLNode()),
-              ..._features.map((feat) {
-                return XMLNode(
-                  tag: 'feature',
-                  attributes: <String, dynamic>{ 'var': feat },
-                );
-              }),
-            ],
-          ),
-        ],
-    ),);
+    await reply(
+      state,
+      'result',
+      [
+        getDiscoInfo(node).toXml(),
+      ],
+    );
 
     return state.copyWith(done: true);
   }
@@ -222,96 +229,63 @@ class DiscoManager extends XmppManagerBase {
   Future<StanzaHandlerData> _onDiscoItemsRequest(Stanza stanza, StanzaHandlerData state) async {
     if (stanza.type != 'get') return state;
 
-    final query = stanza.firstTag('query')!;
-    if (query.attributes['node'] != null) {
-      // TODO(Unknown): Handle the node we specified for XEP-0115
-      await getAttributes().sendStanza(
-        Stanza.iq(
-          to: stanza.from,
-          from: stanza.to,
-          id: stanza.id,
-          type: 'error',
-          children: [
-            XMLNode.xmlns(
-              tag: 'query',
-              // TODO(PapaTutuWawa): Why copy the xmlns?
-              xmlns: query.attributes['xmlns']! as String,
-              attributes: <String, String>{
-                'node': query.attributes['node']! as String,
-              },
-            ),
-            XMLNode(
-              tag: 'error',
-              attributes: <String, dynamic>{
-                'type': 'cancel'
-              },
-              children: [
-                XMLNode.xmlns(
-                  tag: 'not-allowed',
-                  xmlns: fullStanzaXmlns,
-                ),
-              ],
-            ),
-          ],
-        ),
-      );
-      return state.copyWith(done: true);
-    }
-
-    await getAttributes().sendStanza(
-      stanza.reply(
-        children: [
+    final query = stanza.firstTag('query', xmlns: discoItemsXmlns)!;
+    final node = query.attributes['node'] as String?;
+    if (_discoItemsCallbacks.containsKey(node)) {
+      final result = await _discoItemsCallbacks[node]!();
+      await reply(
+        state,
+        'result',
+        [
           XMLNode.xmlns(
             tag: 'query',
             xmlns: discoItemsXmlns,
+            attributes: <String, String>{
+              'node': node!,
+            },
+            children: result.map((item) => item.toXml()).toList(),
           ),
         ],
-      ),
-    );
-    return state.copyWith(done: true);
+      );
+
+      return state.copyWith(done: true);
+    }
+
+    return state;
   }
 
   Future<void> _exitDiscoInfoCriticalSection(DiscoCacheKey key, Result<DiscoError, DiscoInfo> result) async {
-    return _cacheLock.synchronized(() async {
-      // Complete all futures
-      for (final completer in _runningInfoQueries[key]!) {
-        completer.complete(result);
-      }
-
+    await _cacheLock.synchronized(() async {
       // Add to cache if it is a result
       if (result.isType<DiscoInfo>()) {
         _discoInfoCache[key] = result.get<DiscoInfo>();
       }
-      
-      // Remove from the request cache
-      _runningInfoQueries.remove(key);
     });
+
+    await _discoInfoTracker.resolve(key, result);
   }
   
   /// Sends a disco info query to the (full) jid [entity], optionally with node=[node].
   Future<Result<DiscoError, DiscoInfo>> discoInfoQuery(String entity, { String? node, bool shouldEncrypt = true }) async {
     final cacheKey = DiscoCacheKey(entity, node);
     DiscoInfo? info;
-    Completer<Result<DiscoError, DiscoInfo>>? completer;
-    await _cacheLock.synchronized(() async {
+    final ffuture = await _cacheLock.synchronized<Future<Future<Result<DiscoError, DiscoInfo>>?>?>(() async {
       // Check if we already know what the JID supports
       if (_discoInfoCache.containsKey(cacheKey)) {
         info = _discoInfoCache[cacheKey];
+        return null;
       } else {
-        // Is a request running?
-        if (_runningInfoQueries.containsKey(cacheKey)) {
-          completer = Completer();
-          _runningInfoQueries[cacheKey]!.add(completer!);
-        } else {
-          _runningInfoQueries[cacheKey] = List.from(<Completer<DiscoInfo?>>[]);
-        }
+        return _discoInfoTracker.waitFor(cacheKey);
       }
     });
 
     if (info != null) {
       return Result<DiscoError, DiscoInfo>(info);
-    } else if (completer != null) {
-      return completer!.future;
+    } else {
+      final future = await ffuture;
+      if (future != null) {
+        return future;
+      }
     }
 
     final stanza = await getAttributes().sendStanza(
@@ -325,34 +299,17 @@ class DiscoManager extends XmppManagerBase {
       return result;
     }
 
-    final error = stanza.firstTag('error');
-    if (error != null && stanza.attributes['type'] == 'error') {
+    if (stanza.attributes['type'] == 'error') {
+      //final error = stanza.firstTag('error');
       final result = Result<DiscoError, DiscoInfo>(ErrorResponseDiscoError());
       await _exitDiscoInfoCriticalSection(cacheKey, result);
       return result;
     }
     
-    final features = List<String>.empty(growable: true);
-    final identities = List<Identity>.empty(growable: true);
-
-    for (final element in query.children) {
-      if (element.tag == 'feature') {
-        features.add(element.attributes['var']! as String);
-      } else if (element.tag == 'identity') {
-        identities.add(Identity(
-          category: element.attributes['category']! as String,
-          type: element.attributes['type']! as String,
-          name: element.attributes['name'] as String?,
-        ),);
-      }
-    }
-
     final result = Result<DiscoError, DiscoInfo>(
-      DiscoInfo(
-        features,
-        identities,
-        query.findTags('x', xmlns: dataFormsXmlns).map(parseDataForm).toList(),
-        JID.fromString(stanza.attributes['from']! as String),
+      DiscoInfo.fromQuery(
+        query,
+        JID.fromString(entity),
       ),
     );
     await _exitDiscoInfoCriticalSection(cacheKey, result);
@@ -361,6 +318,12 @@ class DiscoManager extends XmppManagerBase {
 
   /// Sends a disco items query to the (full) jid [entity], optionally with node=[node].
   Future<Result<DiscoError, List<DiscoItem>>> discoItemsQuery(String entity, { String? node, bool shouldEncrypt = true }) async {
+    final key = DiscoCacheKey(entity, node);
+    final future = await _discoItemsTracker.waitFor(key);
+    if (future != null) {
+      return future;
+    }
+
     final stanza = await getAttributes()
       .sendStanza(
         buildDiscoItemsQueryStanza(entity, node: node),
@@ -368,12 +331,18 @@ class DiscoManager extends XmppManagerBase {
       ) as Stanza;
 
     final query = stanza.firstTag('query');
-    if (query == null) return Result(InvalidResponseDiscoError());
+    if (query == null) {
+      final result = Result<DiscoError, List<DiscoItem>>(InvalidResponseDiscoError());
+      await _discoItemsTracker.resolve(key, result);
+      return result;
+    }
 
-    final error = stanza.firstTag('error');
-    if (error != null && stanza.type == 'error') {
+    if (stanza.type == 'error') {
+      //final error = stanza.firstTag('error');
       //print("Disco Items error: " + error.toXml());
-      return Result(ErrorResponseDiscoError());
+      final result = Result<DiscoError, List<DiscoItem>>(ErrorResponseDiscoError());
+      await _discoItemsTracker.resolve(key, result);
+      return result;
     }
 
     final items = query.findTags('item').map((node) => DiscoItem(
@@ -382,7 +351,9 @@ class DiscoManager extends XmppManagerBase {
       name: node.attributes['name'] as String?,
     ),).toList();
 
-    return Result(items);
+    final result = Result<DiscoError, List<DiscoItem>>(items);
+    await _discoItemsTracker.resolve(key, result);
+    return result;
   }
 
   /// Queries information about a jid based on its node and capability hash.

packages/moxxmpp/lib/src/xeps/xep_0054.dart

@@ -28,15 +28,9 @@ class VCard {
 }
 
 class VCardManager extends XmppManagerBase {
-  VCardManager() : _lastHash = {}, super();
-  final Map<String, String> _lastHash;
+  VCardManager() : super(vcardManager);
+  final Map<String, String> _lastHash = {};
   
-  @override
-  String getId() => vcardManager;
-
-  @override
-  String getName() => 'vCardManager';
-
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [
     StanzaHandler(

packages/moxxmpp/lib/src/xeps/xep_0060/xep_0060.dart

@@ -69,11 +69,7 @@ class PubSubItem {
 }
 
 class PubSubManager extends XmppManagerBase {
-  @override
-  String getId() => pubsubManager;
-
-  @override
-  String getName() => 'PubsubManager';
+  PubSubManager() : super(pubsubManager);
 
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [

packages/moxxmpp/lib/src/xeps/xep_0066.dart

@@ -8,7 +8,6 @@ import 'package:moxxmpp/src/stringxml.dart';
 
 /// A data class representing the jabber:x:oob tag.
 class OOBData {
-
   const OOBData({ this.url, this.desc });
   final String? url;
   final String? desc;
@@ -32,11 +31,7 @@ XMLNode constructOOBNode(OOBData data) {
 }
 
 class OOBManager extends XmppManagerBase {
-  @override
-  String getName() => 'OOBName';
-
-  @override
-  String getId() => oobManager;
+  OOBManager() : super(oobManager);
 
   @override
   List<String> getDiscoFeatures() => [ oobDataXmlns ];

packages/moxxmpp/lib/src/xeps/xep_0084.dart

@@ -28,24 +28,24 @@ class UserAvatarMetadata {
     this.height,
     this.mime,
   );
+
   /// The amount of bytes in the file
   final int length;
+
   /// The identifier of the avatar
   final String id;
+
   /// Image proportions
   final int width;
   final int height;
+
   /// The MIME type of the avatar
   final String mime;
 }
 
 /// NOTE: This class requires a PubSubManager
 class UserAvatarManager extends XmppManagerBase {
-  @override
-  String getId() => userAvatarManager;
-
-  @override
-  String getName() => 'UserAvatarManager';
+  UserAvatarManager() : super(userAvatarManager);
 
   PubSubManager _getPubSubManager() => getAttributes().getManagerById(pubsubManager)! as PubSubManager;
   

packages/moxxmpp/lib/src/xeps/xep_0085.dart

@@ -39,15 +39,11 @@ ChatState chatStateFromString(String raw) {
 String chatStateToString(ChatState state) => state.toString().split('.').last;
 
 class ChatStateManager extends XmppManagerBase {
+  ChatStateManager() : super(chatStateManager);
+
   @override
   List<String> getDiscoFeatures() => [ chatStateXmlns ];
 
-  @override
-  String getName() => 'ChatStateManager';
-
-  @override
-  String getId() => chatStateManager;
-
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [
     StanzaHandler(

packages/moxxmpp/lib/src/xeps/xep_0115.dart

@@ -1,10 +1,18 @@
 import 'dart:convert';
 import 'package:cryptography/cryptography.dart';
+import 'package:meta/meta.dart';
+import 'package:moxxmpp/src/managers/base.dart';
+import 'package:moxxmpp/src/managers/namespaces.dart';
+import 'package:moxxmpp/src/namespaces.dart';
+import 'package:moxxmpp/src/presence.dart';
 import 'package:moxxmpp/src/rfcs/rfc_4790.dart';
+import 'package:moxxmpp/src/stringxml.dart';
 import 'package:moxxmpp/src/xeps/xep_0030/types.dart';
+import 'package:moxxmpp/src/xeps/xep_0030/xep_0030.dart';
+import 'package:moxxmpp/src/xeps/xep_0414.dart';
 
+@immutable
 class CapabilityHashInfo {
-
   const CapabilityHashInfo(this.ver, this.node, this.hash);
   final String ver;
   final String node;
@@ -57,3 +65,78 @@ Future<String> calculateCapabilityHash(DiscoInfo info, HashAlgorithm algorithm)
   
   return base64.encode((await algorithm.hash(utf8.encode(buffer.toString()))).bytes);
 }
+
+/// A manager implementing the advertising of XEP-0115. It responds to the
+/// disco#info requests on the specified node with the information provided by
+/// the DiscoManager.
+/// NOTE: This manager requires that the DiscoManager is also registered.
+class EntityCapabilitiesManager extends XmppManagerBase {
+  EntityCapabilitiesManager(this._capabilityHashBase) : super(entityCapabilitiesManager);
+
+  /// The string that is both the node under which we advertise the disco info
+  /// and the base for the actual node on which we respond to disco#info requests.
+  final String _capabilityHashBase;
+
+  /// The cached capability hash.
+  String? _capabilityHash;
+
+  @override
+  Future<bool> isSupported() async => true;
+
+  @override
+  List<String> getDiscoFeatures() => [ capsXmlns ];
+
+  /// Computes, if required, the capability hash of the data provided by
+  /// the DiscoManager.
+  Future<String> getCapabilityHash() async {
+    _capabilityHash ??= await calculateCapabilityHash(
+      getAttributes()
+        .getManagerById<DiscoManager>(discoManager)!
+        .getDiscoInfo(null),
+      getHashByName('sha-1')!,
+    );
+
+    return _capabilityHash!;
+  }
+
+  Future<String> _getNode() async {
+    final hash = await getCapabilityHash();
+    return '$_capabilityHashBase#$hash';
+  }
+  
+  Future<DiscoInfo> _onInfoQuery() async {
+    return getAttributes()
+      .getManagerById<DiscoManager>(discoManager)!
+      .getDiscoInfo(await _getNode());
+  }
+
+  Future<List<XMLNode>> _prePresenceSent() async {
+    return [
+      XMLNode.xmlns(
+        tag: 'c',
+        xmlns: capsXmlns,
+        attributes: {
+          'hash': 'sha-1',
+          'node': _capabilityHashBase,
+          'ver': await getCapabilityHash(),
+        },
+      ),
+    ];
+  }
+  
+  @override
+  Future<void> postRegisterCallback() async {
+    await super.postRegisterCallback();
+    
+    getAttributes().getManagerById<DiscoManager>(discoManager)!.registerInfoCallback(
+        await _getNode(),
+        _onInfoQuery,
+      );
+
+    getAttributes()
+      .getManagerById<PresenceManager>(presenceManager)!
+      .registerPreSendCallback(
+        _prePresenceSent,
+      );
+  }
+}

packages/moxxmpp/lib/src/xeps/xep_0184.dart

@@ -24,15 +24,11 @@ XMLNode makeMessageDeliveryResponse(String id) {
 }
 
 class MessageDeliveryReceiptManager extends XmppManagerBase {
+  MessageDeliveryReceiptManager() : super(messageDeliveryReceiptManager);
+
   @override
   List<String> getDiscoFeatures() => [ deliveryXmlns ];
 
-  @override
-  String getName() => 'MessageDeliveryReceiptManager';
-
-  @override
-  String getId() => messageDeliveryReceiptManager;
-
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [
     StanzaHandler(

packages/moxxmpp/lib/src/xeps/xep_0191.dart

@@ -9,16 +9,10 @@ import 'package:moxxmpp/src/stringxml.dart';
 import 'package:moxxmpp/src/xeps/xep_0030/xep_0030.dart';
 
 class BlockingManager extends XmppManagerBase {
-  BlockingManager() : _supported = false, _gotSupported = false, super();
+  BlockingManager() : super(blockingManager);
 
-  bool _supported;
-  bool _gotSupported;
-
-  @override
-  String getId() => blockingManager;
-
-  @override
-  String getName() => 'BlockingManager';
+  bool _supported = false;
+  bool _gotSupported = false;
 
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [

packages/moxxmpp/lib/src/xeps/xep_0198/xep_0198.dart

@@ -21,40 +21,41 @@ const xmlUintMax = 4294967296; // 2**32
 typedef StanzaAckedCallback = bool Function(Stanza stanza);
 
 class StreamManagementManager extends XmppManagerBase {
-
   StreamManagementManager({
     this.ackTimeout = const Duration(seconds: 30),
-  })
-  : _state = StreamManagementState(0, 0),
-    _unackedStanzas = {},
-    _stateLock = Lock(),
-    _streamManagementEnabled = false,
-    _lastAckTimestamp = -1,
-    _pendingAcks = 0,
-    _streamResumed = false,
-    _ackLock = Lock();
+  }) : super(smManager);
+
   /// The queue of stanzas that are not (yet) acked
-  final Map<int, Stanza> _unackedStanzas;
+  final Map<int, Stanza> _unackedStanzas = {};
+
   /// Commitable state of the StreamManagementManager
-  StreamManagementState _state;
+  StreamManagementState _state = StreamManagementState(0, 0);
+
   /// Mutex lock for _state
-  final Lock _stateLock;
+  final Lock _stateLock = Lock();
+
   /// If the have enabled SM on the stream yet
-  bool _streamManagementEnabled;
+  bool _streamManagementEnabled = false;
+
   /// If the current stream has been resumed;
-  bool _streamResumed;
+  bool _streamResumed = false;
+
   /// The time in which the response to an ack is still valid. Counts as a timeout
   /// otherwise
   @internal
   final Duration ackTimeout;
+
   /// The time at which the last ack has been sent
-  int _lastAckTimestamp;
+  int _lastAckTimestamp = -1;
+
   /// The timer to see if we timed the connection out
   Timer? _ackTimer;
+
   /// Counts how many acks we're waiting for
-  int _pendingAcks;
+  int _pendingAcks = 0;
+
   /// Lock for both [_lastAckTimestamp] and [_pendingAcks].
-  final Lock _ackLock;
+  final Lock _ackLock = Lock();
 
   /// Functions for testing
   @visibleForTesting
@@ -120,12 +121,6 @@ class StreamManagementManager extends XmppManagerBase {
   StreamManagementState get state => _state;
 
   bool get streamResumed => _streamResumed;
-  
-  @override
-  String getId() => smManager;
-
-  @override
-  String getName() => 'StreamManagementManager';
 
   @override
   List<NonzaHandler> getNonzaHandlers() => [

packages/moxxmpp/lib/src/xeps/xep_0203.dart

@@ -14,11 +14,7 @@ class DelayedDelivery {
 }
 
 class DelayedDeliveryManager extends XmppManagerBase {
-  @override
-  String getId() => delayedDeliveryManager;
-
-  @override
-  String getName() => 'DelayedDeliveryManager';
+  DelayedDeliveryManager() : super(delayedDeliveryManager);
 
   @override
   Future<bool> isSupported() async => true;

packages/moxxmpp/lib/src/xeps/xep_0280.dart

@@ -14,7 +14,7 @@ import 'package:moxxmpp/src/xeps/xep_0297.dart';
 
 /// This manager class implements support for XEP-0280.
 class CarbonsManager extends XmppManagerBase {
-  CarbonsManager() : super();
+  CarbonsManager() : super(carbonsManager);
 
   /// Indicates that message carbons are enabled.
   bool _isEnabled = false;
@@ -25,12 +25,6 @@ class CarbonsManager extends XmppManagerBase {
   /// Indicates that we know that [CarbonsManager._supported] is accurate.
   bool _gotSupported = false;
   
-  @override
-  String getId() => carbonsManager;
-
-  @override
-  String getName() => 'CarbonsManager';
-
   @override
   List<StanzaHandler> getIncomingPreStanzaHandlers() => [
     StanzaHandler(

packages/moxxmpp/lib/src/xeps/xep_0300.dart

@@ -61,11 +61,7 @@ HashFunction hashFunctionFromName(String name) {
 }
 
 class CryptographicHashManager extends XmppManagerBase {
-  @override
-  String getId() => cryptographicHashManager;
-
-  @override
-  String getName() => 'CryptographicHashManager';
+  CryptographicHashManager() : super(cryptographicHashManager);
 
   @override
   Future<bool> isSupported() async => true;
@@ -81,7 +77,7 @@ class CryptographicHashManager extends XmppManagerBase {
   ];
 
   static Future<List<int>> hashFromData(List<int> data, HashFunction function) async {
-    // TODO(PapaTutuWawa): Implemen the others as well
+    // TODO(PapaTutuWawa): Implement the others as well
     HashAlgorithm algo;
     switch (function) {
       case HashFunction.sha256:

packages/moxxmpp/lib/src/xeps/xep_0308.dart

@@ -17,11 +17,7 @@ XMLNode makeLastMessageCorrectionEdit(String id) {
 }
 
 class LastMessageCorrectionManager extends XmppManagerBase {
-  @override
-  String getName() => 'LastMessageCorrectionManager';
-
-  @override
-  String getId() => lastMessageCorrectionManager;
+  LastMessageCorrectionManager() : super(lastMessageCorrectionManager);
 
   @override
   List<String> getDiscoFeatures() => [ lmcXmlns ];

packages/moxxmpp/lib/src/xeps/xep_0333.dart

@@ -25,11 +25,7 @@ XMLNode makeChatMarker(String tag, String id) {
 }
 
 class ChatMarkerManager extends XmppManagerBase {
-  @override
-  String getName() => 'ChatMarkerManager';
-
-  @override
-  String getId() => chatMarkerManager;
+  ChatMarkerManager() : super(chatMarkerManager);
 
   @override
   List<String> getDiscoFeatures() => [ chatMarkersXmlns ];

packages/moxxmpp/lib/src/xeps/xep_0352.dart

@@ -26,10 +26,10 @@ class CSIInactiveNonza extends XMLNode {
 
 /// A Stub negotiator that is just for "intercepting" the stream feature.
 class CSINegotiator extends XmppFeatureNegotiatorBase {
-  CSINegotiator() : _supported = false, super(11, false, csiXmlns, csiNegotiator);
+  CSINegotiator() : super(11, false, csiXmlns, csiNegotiator);
 
   /// True if CSI is supported. False otherwise.
-  bool _supported;
+  bool _supported = false;
   bool get isSupported => _supported;
   
   @override
@@ -50,15 +50,9 @@ class CSINegotiator extends XmppFeatureNegotiatorBase {
 
 /// The manager requires a CSINegotiator to be registered as a feature negotiator.
 class CSIManager extends XmppManagerBase {
+  CSIManager() : super(csiManager);
 
-  CSIManager() : _isActive = true, super();
-  bool _isActive; 
-
-  @override
-  String getId() => csiManager;
-
-  @override
-  String getName() => 'CSIManager';
+  bool _isActive = true;
 
   @override
   Future<bool> isSupported() async {

packages/moxxmpp/lib/src/xeps/xep_0359.dart

@@ -13,7 +13,6 @@ import 'package:moxxmpp/src/xeps/xep_0030/xep_0030.dart';
 /// NOTE: [StableStanzaId.stanzaId] must not be confused with the actual id attribute of
 ///       the message stanza.
 class StableStanzaId {
-
   const StableStanzaId({ this.originId, this.stanzaId, this.stanzaIdBy });
   final String? originId;
   final String? stanzaId;
@@ -29,11 +28,7 @@ XMLNode makeOriginIdElement(String id) {
 }
 
 class StableIdManager extends XmppManagerBase {
-  @override
-  String getName() => 'StableIdManager';
-
-  @override
-  String getId() => stableIdManager;
+  StableIdManager() : super(stableIdManager);
 
   @override
   List<String> getDiscoFeatures() => [ stableIdXmlns ];

packages/moxxmpp/lib/src/xeps/xep_0363/xep_0363.dart

@@ -41,17 +41,19 @@ Map<String, String> prepareHeaders(Map<String, String> headers) {
 }
 
 class HttpFileUploadManager extends XmppManagerBase {
-  HttpFileUploadManager() : _gotSupported = false, _supported = false, super();
+  HttpFileUploadManager() : super(httpFileUploadManager);
+
+  /// The entity that we will request file uploads from, if discovered.
   JID? _entityJid;
+
+  /// The maximum file upload file size, if advertised and discovered.
   int? _maxUploadSize;
-  bool _gotSupported;
-  bool _supported;
 
-  @override
-  String getId() => httpFileUploadManager;
+  /// Flag, if we every tried to discover the upload entity.
+  bool _gotSupported = false;
 
-  @override
-  String getName() => 'HttpFileUploadManager';
+  /// Flag, if we can use HTTP File Upload
+  bool _supported = false;
 
   /// Returns whether the entity provided an identity that tells us that we can ask it
   /// for an HTTP upload slot.

packages/moxxmpp/lib/src/xeps/xep_0380.dart

@@ -53,20 +53,12 @@ XMLNode buildEmeElement(ExplicitEncryptionType type) {
 }
 
 class EmeManager extends XmppManagerBase {
-
-  EmeManager() : super();
-
-  @override
-  String getId() => emeManager;
-
-  @override
-  String getName() => 'EmeManager';
-
+  EmeManager() : super(emeManager);
   @override
   Future<bool> isSupported() async => true;
 
   @override
-  List<String> getDiscoFeatures() => [emeXmlns];
+  List<String> getDiscoFeatures() => [ emeXmlns ];
   
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [

packages/moxxmpp/lib/src/xeps/xep_0384/xep_0384.dart

@@ -42,12 +42,9 @@ const _doNotEncryptList = [
   DoNotEncrypt('stanza-id', stableIdXmlns),
 ];
 
+@mustCallSuper
 abstract class BaseOmemoManager extends XmppManagerBase {
-  @override
-  String getId() => omemoManager;
-
-  @override
-  String getName() => 'OmemoManager';
+  BaseOmemoManager() : super(omemoManager);
 
   // TODO(Unknown): Technically, this is not always true
   @override
@@ -318,11 +315,12 @@ abstract class BaseOmemoManager extends XmppManagerBase {
     }
 
     final toJid = JID.fromString(stanza.to!).toBare();
-    if (!(await shouldEncryptStanza(toJid, stanza))) {
-      logger.finest('shouldEncryptStanza returned false for message to $toJid. Not encrypting.');
+    final shouldEncryptResult = await shouldEncryptStanza(toJid, stanza);
+    if (!shouldEncryptResult && !state.forceEncryption) {
+      logger.finest('Not encrypting stanza for $toJid: Both shouldEncryptStanza and forceEncryption are false.');
       return state;
     } else {
-      logger.finest('shouldEncryptStanza returned true for message to $toJid.');
+      logger.finest('Encrypting stanza for $toJid: shouldEncryptResult=$shouldEncryptResult, forceEncryption=${state.forceEncryption}');
     }
 
     final toEncrypt = List<XMLNode>.empty(growable: true);
@@ -357,6 +355,11 @@ abstract class BaseOmemoManager extends XmppManagerBase {
       other['encryption_error_devices'] = result.deviceEncryptionErrors;
       return state.copyWith(
         other: other,
+        // If we have no device list for toJid, then the contact most likely does not
+        // support OMEMO:2
+        cancelReason: result.jidEncryptionErrors[toJid.toString()] is NoKeyMaterialAvailableException ?
+          OmemoNotSupportedForContactException() :
+          UnknownOmemoError(),
         cancel: true,
       );
     }
@@ -453,9 +456,15 @@ abstract class BaseOmemoManager extends XmppManagerBase {
         );
       }
 
-      children.addAll(
-        envelope.firstTag('content')!.children,
-      );
+      final envelopeChildren = envelope.firstTag('content')?.children;
+      if (envelopeChildren != null) {
+        children.addAll(
+          // Do not add forbidden elements from the envelope 
+          envelopeChildren.where(shouldEncryptElement),
+        );
+      } else {
+        logger.warning('Invalid envelope element: No <content /> element');
+      }
 
       if (!checkAffixElements(envelope, stanza.from!, ourJid)) {
         other['encryption_error'] = InvalidAffixElementsException();

packages/moxxmpp/lib/src/xeps/xep_0385.dart

@@ -8,7 +8,6 @@ import 'package:moxxmpp/src/stringxml.dart';
 import 'package:moxxmpp/src/xeps/staging/extensible_file_thumbnails.dart';
 
 class StatelessMediaSharingData {
-
   const StatelessMediaSharingData({ required this.mediaType, required this.size, required this.description, required this.hashes, required this.url, required this.thumbnails });
   final String mediaType;
   final int size;
@@ -63,11 +62,7 @@ StatelessMediaSharingData parseSIMSElement(XMLNode node) {
 }
 
 class SIMSManager extends XmppManagerBase {
-  @override
-  String getName() => 'SIMSManager';
-
-  @override
-  String getId() => simsManager;
+  SIMSManager() : super(simsManager);
 
   @override
   List<String> getDiscoFeatures() => [ simsXmlns ];

packages/moxxmpp/lib/src/xeps/xep_0424.dart

@@ -12,11 +12,7 @@ class MessageRetractionData {
 }
 
 class MessageRetractionManager extends XmppManagerBase {
-  @override
-  String getName() => 'MessageRetractionManager';
-
-  @override
-  String getId() => messageRetractionManager;
+  MessageRetractionManager() : super(messageRetractionManager);
 
   @override
   List<String> getDiscoFeatures() => [ messageRetractionXmlns ];

packages/moxxmpp/lib/src/xeps/xep_0444.dart

@@ -29,15 +29,11 @@ class MessageReactions {
 }
 
 class MessageReactionsManager extends XmppManagerBase {
+  MessageReactionsManager() : super(messageReactionsManager);
+
   @override
   List<String> getDiscoFeatures() => [ messageReactionsXmlns ];
 
-  @override
-  String getName() => 'MessageReactionsManager';
-
-  @override
-  String getId() => messageReactionsManager;
-
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [
     StanzaHandler(

packages/moxxmpp/lib/src/xeps/xep_0447.dart

@@ -105,11 +105,7 @@ class StatelessFileSharingData {
 }
 
 class SFSManager extends XmppManagerBase {
-  @override
-  String getName() => 'SFSManager';
-
-  @override
-  String getId() => sfsManager;
+  SFSManager() : super(sfsManager);
 
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [

packages/moxxmpp/lib/src/xeps/xep_0449.dart

@@ -225,11 +225,7 @@ class StickerPack {
 }
 
 class StickersManager extends XmppManagerBase {
-  @override
-  String getId() => stickersManager;
-
-  @override
-  String getName() => 'StickersManager';
+  StickersManager() : super(stickersManager);
 
   @override
   Future<bool> isSupported() async => true;

packages/moxxmpp/lib/src/xeps/xep_0461.dart

@@ -9,14 +9,14 @@ import 'package:moxxmpp/src/stanza.dart';
 /// Data summarizing the XEP-0461 data.
 class ReplyData {
   const ReplyData({
-    required this.to,
     required this.id,
+    this.to,
     this.start,
     this.end,
   });
 
   /// The bare JID to whom the reply applies to
-  final String to;
+  final String? to;
 
   /// The stanza ID of the message that is replied to
   final String id;
@@ -66,12 +66,13 @@ class QuoteData {
 /// A manager implementing support for parsing XEP-0461 metadata. The
 /// MessageRepliesManager itself does not modify the body of the message.
 class MessageRepliesManager extends XmppManagerBase {
-  @override
-  String getName() => 'MessageRepliesManager';
+  MessageRepliesManager() : super(messageRepliesManager);
 
   @override
-  String getId() => messageRepliesManager;
-
+  List<String> getDiscoFeatures() => [
+    replyXmlns,
+  ];
+  
   @override
   List<StanzaHandler> getIncomingStanzaHandlers() => [
     StanzaHandler(
@@ -90,7 +91,7 @@ class MessageRepliesManager extends XmppManagerBase {
   Future<StanzaHandlerData> _onMessage(Stanza stanza, StanzaHandlerData state) async {
     final reply = stanza.firstTag('reply', xmlns: replyXmlns)!;
     final id = reply.attributes['id']! as String;
-    final to = reply.attributes['to']! as String;
+    final to = reply.attributes['to'] as String?;
     int? start;
     int? end;
 
@@ -102,11 +103,13 @@ class MessageRepliesManager extends XmppManagerBase {
       end = int.parse(body.attributes['end']! as String);
     }
 
-    return state.copyWith(reply: ReplyData(
+    return state.copyWith(
+      reply: ReplyData(
         id: id,
         to: to,
         start: start,
         end: end,
-    ),);
+      ),
+    );
   }
 }

packages/moxxmpp/moxxmpp.doap

@@ -0,0 +1,276 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<rdf:RDF xmlns:rdf='http://www.w3.org/1999/02/22-rdf-syntax-ns#'
+         xmlns='http://usefulinc.com/ns/doap#'
+	 xmlns:foaf='http://xmlns.com/foaf/0.1/'
+	 xmlns:xmpp='https://linkmauve.fr/ns/xmpp-doap#'>
+  <Project xml:lang='en'>
+    <name>moxxmpp</name>
+    <created>2021-12-26</created>
+    <homepage rdf:resource='https://codeberg.org/moxxy/moxxmpp'/>
+    <os>Linux</os>
+    <os>Windows</os>
+    <os>macOS</os>
+    <os>Android</os>
+    <os>iOS</os>
+
+    <programming-language>Dart</programming-language>
+
+    <maintainer>
+      <foaf:Person>
+	<foaf:name>Alexander "Polynomdivision"</foaf:name>
+	<foaf:homepage rdf:resource="https://blog.polynom.me" />
+      </foaf:Person>
+    </maintainer>
+
+    <implements rdf:resource="https://xmpp.org/rfcs/rfc6120.html" />
+
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0004.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>2.13.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0030.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>2.5rc3</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0054.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:version>1.2</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0060.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:version>1.24.1</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0066.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:note xml:lang="en">Only jabber:x:oob</xmpp:note>
+	<xmpp:version>1.5</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0084.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:note xml:lang="en">Receiving data</xmpp:note>
+	<xmpp:version>1.1.4</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0085.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>2.1</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0115.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:version>1.5.2</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0153.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:version>1.1</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0184.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>1.4.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0191.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>1.3.0</xmpp:version>
+	<xmpp:note xml:lang="en">Not plugged into the UI</xmpp:note>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0198.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>1.6</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0280.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>1.0.1</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0297.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:note xml:lang="en">Exists only as part of support for XEP-0280</xmpp:note>
+	<xmpp:version>1.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0300.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:note xml:lang="en">Supports only Sha256, Sha512 and blake2b512</xmpp:note>
+	<xmpp:version>1.0.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0308.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>1.2.1</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0333.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:note xml:lang="en">Read-only support</xmpp:note>
+	<xmpp:version>0.4</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0334.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:note xml:lang="en">Write-only support</xmpp:note>
+	<xmpp:version>0.3.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0352.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>1.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0359.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>0.6.1</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0363.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:version>1.1.0</xmpp:version>
+	<xmpp:note xml:lang="en">Only handles the success case; not accessible via the App</xmpp:note>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0368.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:version>1.1.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0380.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>0.4.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0384.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>0.8.3</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0420.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:version>0.4.1</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0424.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>0.3.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0444.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>0.1.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0446.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>0.2.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0447.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>0.1.2</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0448.html" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:version>0.2.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0449.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>0.1.1</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0461.html" />
+	<xmpp:status>complete</xmpp:status>
+	<xmpp:version>0.2.0</xmpp:version>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://codeberg.org/moxxy/custom-xeps/src/branch/master/xep-xxxx-extensible-file-thumbnails.md" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:version>0.2.1</xmpp:version>
+	<xmpp:note xml:lang="en">Only Blurhash is implemented</xmpp:note>
+      </xmpp:SupportedXep>
+    </implements>
+    <implements>
+      <xmpp:SupportedXep>
+	<xmpp:xep rdf:resource="https://codeberg.org/moxxy/custom-xeps/src/branch/master/xep-xxxx-file-upload-notification.md" />
+	<xmpp:status>partial</xmpp:status>
+	<xmpp:version>0.0.5</xmpp:version>
+	<xmpp:note xml:lang="en">Sending and receiving implemented; cancellation not implemented</xmpp:note>
+      </xmpp:SupportedXep>
+    </implements>
+  </Project>
+</rdf:RDF>

packages/moxxmpp/pubspec.yaml

@@ -1,6 +1,6 @@
 name: moxxmpp
 description: A pure-Dart XMPP library
-version: 0.1.6+1
+version: 0.2.0
 homepage: https://codeberg.org/moxxy/moxxmpp
 publish_to: https://git.polynom.me/api/packages/Moxxy/pub
 
@@ -21,7 +21,7 @@ dependencies:
    version: ^0.1.5
   omemo_dart:
     hosted: https://git.polynom.me/api/packages/PapaTutuWawa/pub
-    version: ^0.4.2
+    version: ^0.4.3
   random_string: ^2.3.1
   saslprep: ^1.0.2
   synchronized: ^3.0.0+2

packages/moxxmpp/test/async_queue_test.dart

@@ -0,0 +1,43 @@
+import 'package:moxxmpp/src/util/queue.dart';
+import 'package:test/test.dart';
+
+void main() {
+  test('Test the async queue', () async {
+    final queue = AsyncQueue();
+    int future1Finish = 0;
+    int future2Finish = 0;
+    int future3Finish = 0;
+
+    await queue.addJob(() => Future<void>.delayed(const Duration(seconds: 3), () => future1Finish = DateTime.now().millisecondsSinceEpoch));
+    await queue.addJob(() => Future<void>.delayed(const Duration(seconds: 3), () => future2Finish = DateTime.now().millisecondsSinceEpoch));
+    await queue.addJob(() => Future<void>.delayed(const Duration(seconds: 3), () => future3Finish = DateTime.now().millisecondsSinceEpoch));
+
+    await Future<void>.delayed(const Duration(seconds: 12));
+
+    // The three futures must be done
+    expect(future1Finish != 0, true);
+    expect(future2Finish != 0, true);
+    expect(future3Finish != 0, true);
+
+    // The end times of the futures must be ordered (on a timeline)
+    // |-- future1Finish -- future2Finish -- future3Finish --|
+    expect(
+      future1Finish < future2Finish && future1Finish < future3Finish,
+      true,
+    );
+    expect(
+      future2Finish < future3Finish && future2Finish > future1Finish,
+      true,
+    );
+    expect(
+      future3Finish > future1Finish && future3Finish > future2Finish,
+      true,
+    );
+
+    // The queue must be empty at the end
+    expect(queue.queue.isEmpty, true);
+
+    // The queue must not be executing anything at the end
+    expect(queue.isRunning, false);
+  });
+}

packages/moxxmpp/test/awaiter_test.dart

@@ -0,0 +1,104 @@
+import 'package:moxxmpp/moxxmpp.dart';
+import 'package:moxxmpp/src/awaiter.dart';
+import 'package:test/test.dart';
+
+void main() {
+  final bareJid = JID('moxxmpp', 'server3.example', '');
+
+  test('Test awaiting an awaited stanza with a from attribute', () async {
+    final awaiter = StanzaAwaiter();
+
+    // "Send" a stanza
+    final future = await awaiter.addPending('user1@server.example', 'abc123', 'iq');
+
+    // Receive the wrong answer
+    final result1 = await awaiter.onData(
+      XMLNode.fromString('<iq from="user3@server.example" id="abc123" type="result" />'),
+      bareJid,
+    );
+    expect(result1, false);
+    final result2 = await awaiter.onData(
+      XMLNode.fromString('<iq from="user1@server.example" id="lol" type="result" />'),
+      bareJid,
+    );
+    expect(result2, false);
+
+    // Receive the correct answer
+    final stanza = XMLNode.fromString('<iq from="user1@server.example" id="abc123" type="result" />');
+    final result3 = await awaiter.onData(
+      stanza,
+      bareJid,
+    );
+    expect(result3, true);
+    expect(await future, stanza);
+  });
+
+  test('Test awaiting an awaited stanza without a from attribute', () async {
+    final awaiter = StanzaAwaiter();
+
+    // "Send" a stanza
+    final future = await awaiter.addPending(bareJid.toString(), 'abc123', 'iq');
+
+    // Receive the wrong answer
+    final result1 = await awaiter.onData(
+      XMLNode.fromString('<iq id="lol" type="result" />'),
+      bareJid,
+    );
+    expect(result1, false);
+   
+    // Receive the correct answer
+    final stanza = XMLNode.fromString('<iq id="abc123" type="result" />');
+    final result2 = await awaiter.onData(
+      stanza,
+      bareJid,
+    );
+    expect(result2, true);
+    expect(await future, stanza);
+  });
+
+  test('Test awaiting a stanza that was already awaited', () async {
+    final awaiter = StanzaAwaiter();
+
+    // "Send" a stanza
+    final future = await awaiter.addPending(bareJid.toString(), 'abc123', 'iq');
+
+    // Receive the correct answer
+    final stanza = XMLNode.fromString('<iq id="abc123" type="result" />');
+    final result1 = await awaiter.onData(
+      stanza,
+      bareJid,
+    );
+    expect(result1, true);
+    expect(await future, stanza);
+
+    // Receive it again
+    final result2 = await awaiter.onData(
+      stanza,
+      bareJid,
+    );
+    expect(result2, false);
+  });
+
+  test('Test ignoring a stanza that has the wrong tag', () async {
+    final awaiter = StanzaAwaiter();
+
+    // "Send" a stanza
+    final future = await awaiter.addPending(bareJid.toString(), 'abc123', 'iq');
+
+    // Receive the wrong answer
+    final stanza = XMLNode.fromString('<iq id="abc123" type="result" />');
+    final result1 = await awaiter.onData(
+      XMLNode.fromString('<message id="abc123" type="result" />'),
+      bareJid,
+    );
+    expect(result1, false);
+
+    // Receive the correct answer
+    final result2 = await awaiter.onData(
+      stanza,
+      bareJid,
+    );
+    expect(result2, true);
+    expect(await future, stanza);
+  });
+}

packages/moxxmpp/test/negotiator_test.dart

@@ -54,16 +54,20 @@ void main() {
     ],
   );
   
-  final connection = XmppConnection(TestingReconnectionPolicy(), stubSocket)
-    ..registerFeatureNegotiators([
+  final connection = XmppConnection(
+    TestingReconnectionPolicy(),
+    AlwaysConnectedConnectivityManager(),
+    stubSocket,
+  )..registerFeatureNegotiators([
       StubNegotiator1(),
       StubNegotiator2(),
     ])
     ..registerManagers([
-      PresenceManager('http://moxxmpp.example'),
+      PresenceManager(),
       RosterManager(TestingRosterStateManager('', [])),
-      DiscoManager(),
+      DiscoManager([]),
       PingManager(),
+      EntityCapabilitiesManager('http://moxxmpp.example'),
     ])
     ..setConnectionSettings(
       ConnectionSettings(

packages/moxxmpp/test/stanza_test.dart

@@ -1,50 +0,0 @@
-import 'package:moxxmpp/moxxmpp.dart';
-import 'package:test/test.dart';
-
-void main() {
-  test('Make sure reply does not copy the children', () {
-      final stanza = Stanza.iq(
-        to: 'hallo',
-        from: 'world',
-        id: 'abc123',
-        type: 'get',
-        children: [
-          XMLNode(tag: 'test-tag'),
-          XMLNode(tag: 'test-tag2')
-        ],
-      );
-
-      final reply = stanza.reply();
-
-      expect(reply.children, []);
-      expect(reply.type, 'result');
-      expect(reply.from, stanza.to);
-      expect(reply.to, stanza.from);
-      expect(reply.id, stanza.id);
-  });
-
-  test('Make sure reply includes the new children', () {
-      final stanza = Stanza.iq(
-        to: 'hallo',
-        from: 'world',
-        id: 'abc123',
-        type: 'get',
-        children: [
-          XMLNode(tag: 'test-tag'),
-          XMLNode(tag: 'test-tag2')
-        ],
-      );
-
-      final reply = stanza.reply(
-        children: [
-          XMLNode.xmlns(
-            tag: 'test',
-            xmlns: 'test',
-          )
-        ],
-      );
-
-      expect(reply.children.length, 1);
-      expect(reply.firstTag('test') != null, true);
-  });
-}

packages/moxxmpp/test/wait_test.dart

@@ -0,0 +1,40 @@
+import 'package:test/test.dart';
+import 'package:moxxmpp/src/util/wait.dart';
+
+void main() {
+  test('Test adding and resolving', () async {
+    // ID -> Milliseconds since epoch
+    final tracker = WaitForTracker<int, int>();
+
+    int r2 = 0;
+    int r3 = 0;
+    
+    // Queue some jobs
+    final r1 = await tracker.waitFor(0);
+    expect(r1, null);
+    
+    tracker
+      .waitFor(0)
+      .then((result) async {
+        expect(result != null, true);
+        r2 = await result!;
+      });
+    tracker
+      .waitFor(0)
+      .then((result) async {
+        expect(result != null, true);
+        r3 = await result!;
+      });
+
+    final c = await tracker.waitFor(1);
+    expect(c, null);
+
+    // Resolve jobs
+    await tracker.resolve(0, 42);
+    await tracker.resolve(1, 25);
+    await tracker.resolve(2, -1);
+
+    expect(r2, 42);
+    expect(r3, 42);
+  });
+}

packages/moxxmpp/test/xeps/xep_0004_test.dart

@@ -3,14 +3,14 @@ import 'package:test/test.dart';
 
 void main() {
   test('Parsing', () {
-      const testData = "<x xmlns='jabber:x:data' type='result'><field var='FORM_TYPE' type='hidden'><value>urn:xmpp:dataforms:softwareinfo</value></field><field var='ip_version' type='text-multi' ><value>ipv4</value><value>ipv6</value></field><field var='os'><value>Mac</value></field><field var='os_version'><value>10.5.1</value></field><field var='software'><value>Psi</value></field><field var='software_version'><value>0.11</value></field></x>";
+    const testData = "<x xmlns='jabber:x:data' type='result'><field var='FORM_TYPE' type='hidden'><value>urn:xmpp:dataforms:softwareinfo</value></field><field var='ip_version' type='text-multi' ><value>ipv4</value><value>ipv6</value></field><field var='os'><value>Mac</value></field><field var='os_version'><value>10.5.1</value></field><field var='software'><value>Psi</value></field><field var='software_version'><value>0.11</value></field></x>";
 
-      final form = parseDataForm(XMLNode.fromString(testData));
-      expect(form.getFieldByVar('FORM_TYPE')?.values.first, 'urn:xmpp:dataforms:softwareinfo');
-      expect(form.getFieldByVar('ip_version')?.values, [ 'ipv4', 'ipv6' ]);
-      expect(form.getFieldByVar('os')?.values.first, 'Mac');
-      expect(form.getFieldByVar('os_version')?.values.first, '10.5.1');
-      expect(form.getFieldByVar('software')?.values.first, 'Psi');
-      expect(form.getFieldByVar('software_version')?.values.first, '0.11');
+    final form = parseDataForm(XMLNode.fromString(testData));
+    expect(form.getFieldByVar('FORM_TYPE')?.values.first, 'urn:xmpp:dataforms:softwareinfo');
+    expect(form.getFieldByVar('ip_version')?.values, [ 'ipv4', 'ipv6' ]);
+    expect(form.getFieldByVar('os')?.values.first, 'Mac');
+    expect(form.getFieldByVar('os_version')?.values.first, '10.5.1');
+    expect(form.getFieldByVar('software')?.values.first, 'Psi');
+    expect(form.getFieldByVar('software_version')?.values.first, '0.11');
   });
 }

packages/moxxmpp/test/xeps/xep_0030_test.dart

@@ -1,9 +1,13 @@
 import 'package:moxxmpp/moxxmpp.dart';
+import 'package:moxxmpp/src/xeps/xep_0030/cache.dart';
 import 'package:test/test.dart';
 
+import '../helpers/logging.dart';
 import '../helpers/xmpp.dart';
 
 void main() {
+  initLogger();
+
   test('Test having multiple disco requests for the same JID', () async {
     final fakeSocket = StubTCPSocket(
       play: [
@@ -53,7 +57,7 @@ void main() {
           ignoreId: true,
         ),
         StringExpectation(
-          "<presence xmlns='jabber:client' from='polynomdivision@test.server/MU29eEZn'><show>chat</show><c xmlns='http://jabber.org/protocol/caps' hash='sha-1' node='http://moxxmpp.example' ver='QRTBC5cg/oYd+UOTYazSQR4zb/I=' /></presence>",
+          "<presence xmlns='jabber:client' from='polynomdivision@test.server/MU29eEZn'><show>chat</show><c xmlns='http://jabber.org/protocol/caps' hash='sha-1' node='http://moxxmpp.example' ver='3QvQ2RAy45XBDhArjxy/vEWMl+E=' /></presence>",
           '',
         ),
         StanzaExpectation(
@@ -65,7 +69,11 @@ void main() {
 
       ],
     );
-    final XmppConnection conn = XmppConnection(TestingReconnectionPolicy(), socket: fakeSocket);
+    final XmppConnection conn = XmppConnection(
+      TestingReconnectionPolicy(),
+      AlwaysConnectedConnectivityManager(),
+      fakeSocket,
+    );
     conn.setConnectionSettings(ConnectionSettings(
         jid: JID.fromString('polynomdivision@test.server'),
         password: 'aaaa',
@@ -73,10 +81,11 @@ void main() {
         allowPlainAuth: true,
     ),);
     conn.registerManagers([
-      PresenceManager('http://moxxmpp.example'),
-      RosterManager(),
-      DiscoManager(),
+      PresenceManager(),
+      RosterManager(TestingRosterStateManager(null, [])),
+      DiscoManager([]),
       PingManager(),
+      EntityCapabilitiesManager('http://moxxmpp.example'),
     ]);
     conn.registerFeatureNegotiators(
       [
@@ -97,7 +106,7 @@ void main() {
 
     await Future.delayed(const Duration(seconds: 1));
     expect(
-      disco.getRunningInfoQueries(DiscoCacheKey(jid.toString(), null)).length,
+      disco.infoTracker.getRunningTasks(DiscoCacheKey(jid.toString(), null)).length,
       1,
     );
     fakeSocket.injectRawXml("<iq type='result' id='${fakeSocket.lastId!}' from='romeo@montague.lit/orchard' to='polynomdivision@test.server/MU29eEZn' xmlns='jabber:client'><query xmlns='http://jabber.org/protocol/disco#info' /></iq>");
@@ -106,6 +115,6 @@ void main() {
     
     expect(fakeSocket.getState(), 6);
     expect(await result1, await result2);
-    expect(disco.hasInfoQueriesRunning(), false);
+    expect(disco.infoTracker.hasTasksRunning(), false);
   });
 }

packages/moxxmpp/test/xeps/xep_0115_test.dart

@@ -4,164 +4,167 @@ import 'package:test/test.dart';
 
 void main() {
   test('Test XEP example', () async {
-      final data = DiscoInfo(
-        [
-          'http://jabber.org/protocol/caps',
-          'http://jabber.org/protocol/disco#info',
-          'http://jabber.org/protocol/disco#items',
-          'http://jabber.org/protocol/muc'
-        ],
-        [
-          Identity(
-            category: 'client',
-            type: 'pc',
-            name: 'Exodus 0.9.1',
-          )
-        ],
-        [],
-        JID.fromString('some@user.local/test'),
-      );
+    final data = DiscoInfo(
+      [
+        'http://jabber.org/protocol/caps',
+        'http://jabber.org/protocol/disco#info',
+        'http://jabber.org/protocol/disco#items',
+        'http://jabber.org/protocol/muc'
+      ],
+      [
+        Identity(
+          category: 'client',
+          type: 'pc',
+          name: 'Exodus 0.9.1',
+        )
+      ],
+      [],
+      null,
+      JID.fromString('some@user.local/test'),
+    );
 
-      final hash = await calculateCapabilityHash(data, Sha1());
-      expect(hash, 'QgayPKawpkPSDYmwT/WM94uAlu0=');
+    final hash = await calculateCapabilityHash(data, Sha1());
+    expect(hash, 'QgayPKawpkPSDYmwT/WM94uAlu0=');
   });
 
   test('Test complex generation example', () async {
-      const extDiscoDataString = "<x xmlns='jabber:x:data' type='result'><field var='FORM_TYPE' type='hidden'><value>urn:xmpp:dataforms:softwareinfo</value></field><field var='ip_version' type='text-multi' ><value>ipv4</value><value>ipv6</value></field><field var='os'><value>Mac</value></field><field var='os_version'><value>10.5.1</value></field><field var='software'><value>Psi</value></field><field var='software_version'><value>0.11</value></field></x>";
-      final data = DiscoInfo(
-        [
-          'http://jabber.org/protocol/caps',
-          'http://jabber.org/protocol/disco#info',
-          'http://jabber.org/protocol/disco#items',
-          'http://jabber.org/protocol/muc'
-        ],
-        [
-          const Identity(
-            category: 'client',
-            type: 'pc',
-            name: 'Psi 0.11',
-            lang: 'en',
-          ),
-          const Identity(
-            category: 'client',
-            type: 'pc',
-            name: 'Ψ 0.11',
-            lang: 'el',
-          ),
-        ],
-        [ parseDataForm(XMLNode.fromString(extDiscoDataString)) ],
-        JID.fromString('some@user.local/test'),
-      );
+    const extDiscoDataString = "<x xmlns='jabber:x:data' type='result'><field var='FORM_TYPE' type='hidden'><value>urn:xmpp:dataforms:softwareinfo</value></field><field var='ip_version' type='text-multi' ><value>ipv4</value><value>ipv6</value></field><field var='os'><value>Mac</value></field><field var='os_version'><value>10.5.1</value></field><field var='software'><value>Psi</value></field><field var='software_version'><value>0.11</value></field></x>";
+    final data = DiscoInfo(
+      [
+        'http://jabber.org/protocol/caps',
+        'http://jabber.org/protocol/disco#info',
+        'http://jabber.org/protocol/disco#items',
+        'http://jabber.org/protocol/muc'
+      ],
+      [
+        const Identity(
+          category: 'client',
+          type: 'pc',
+          name: 'Psi 0.11',
+          lang: 'en',
+        ),
+        const Identity(
+          category: 'client',
+          type: 'pc',
+          name: 'Ψ 0.11',
+          lang: 'el',
+        ),
+      ],
+      [ parseDataForm(XMLNode.fromString(extDiscoDataString)) ],
+      null,
+      JID.fromString('some@user.local/test'),
+    );
 
-      final hash = await calculateCapabilityHash(data, Sha1());
-      expect(hash, 'q07IKJEyjvHSyhy//CH0CxmKi8w=');
+    final hash = await calculateCapabilityHash(data, Sha1());
+    expect(hash, 'q07IKJEyjvHSyhy//CH0CxmKi8w=');
   });
   
   test('Test Gajim capability hash computation', () async {
-      // TODO: This one fails
-      /*
-      final data = DiscoInfo(
-        features: [
-          "http://jabber.org/protocol/bytestreams",
-          "http://jabber.org/protocol/muc",
-          "http://jabber.org/protocol/commands",
-          "http://jabber.org/protocol/disco#info",
-          "jabber:iq:last",
-          "jabber:x:data",
-          "jabber:x:encrypted",
-          "urn:xmpp:ping",
-          "http://jabber.org/protocol/chatstates",
-          "urn:xmpp:receipts",
-          "urn:xmpp:time",
-          "jabber:iq:version",
-          "http://jabber.org/protocol/rosterx",
-          "urn:xmpp:sec-label:0",
-          "jabber:x:conference",
-          "urn:xmpp:message-correct:0",
-          "urn:xmpp:chat-markers:0",
-          "urn:xmpp:eme:0",
-          "http://jabber.org/protocol/xhtml-im",
-          "urn:xmpp:hashes:2",
-          "urn:xmpp:hash-function-text-names:md5",
-          "urn:xmpp:hash-function-text-names:sha-1",
-          "urn:xmpp:hash-function-text-names:sha-256",
-          "urn:xmpp:hash-function-text-names:sha-512",
-          "urn:xmpp:hash-function-text-names:sha3-256",
-          "urn:xmpp:hash-function-text-names:sha3-512",
-          "urn:xmpp:hash-function-text-names:id-blake2b256",
-          "urn:xmpp:hash-function-text-names:id-blake2b512",
-          "urn:xmpp:jingle:1",
-          "urn:xmpp:jingle:apps:file-transfer:5",
-          "urn:xmpp:jingle:security:xtls:0",
-          "urn:xmpp:jingle:transports:s5b:1",
-          "urn:xmpp:jingle:transports:ibb:1",
-          "urn:xmpp:avatar:metadata+notify",
-          "urn:xmpp:message-moderate:0",
-          "http://jabber.org/protocol/tune+notify",
-          "http://jabber.org/protocol/geoloc+notify",
-          "http://jabber.org/protocol/nick+notify",
-          "eu.siacs.conversations.axolotl.devicelist+notify",
-        ],
-        identities: [
-          Identity(
-            category: "client",
-            type: "pc",
-            name: "Gajim"
-          )
-        ]
-      );
+    // TODO: This one fails
+    /*
+    final data = DiscoInfo(
+      features: [
+        "http://jabber.org/protocol/bytestreams",
+        "http://jabber.org/protocol/muc",
+        "http://jabber.org/protocol/commands",
+        "http://jabber.org/protocol/disco#info",
+        "jabber:iq:last",
+        "jabber:x:data",
+        "jabber:x:encrypted",
+        "urn:xmpp:ping",
+        "http://jabber.org/protocol/chatstates",
+        "urn:xmpp:receipts",
+        "urn:xmpp:time",
+        "jabber:iq:version",
+        "http://jabber.org/protocol/rosterx",
+        "urn:xmpp:sec-label:0",
+        "jabber:x:conference",
+        "urn:xmpp:message-correct:0",
+        "urn:xmpp:chat-markers:0",
+        "urn:xmpp:eme:0",
+        "http://jabber.org/protocol/xhtml-im",
+        "urn:xmpp:hashes:2",
+        "urn:xmpp:hash-function-text-names:md5",
+        "urn:xmpp:hash-function-text-names:sha-1",
+        "urn:xmpp:hash-function-text-names:sha-256",
+        "urn:xmpp:hash-function-text-names:sha-512",
+        "urn:xmpp:hash-function-text-names:sha3-256",
+        "urn:xmpp:hash-function-text-names:sha3-512",
+        "urn:xmpp:hash-function-text-names:id-blake2b256",
+        "urn:xmpp:hash-function-text-names:id-blake2b512",
+        "urn:xmpp:jingle:1",
+        "urn:xmpp:jingle:apps:file-transfer:5",
+        "urn:xmpp:jingle:security:xtls:0",
+        "urn:xmpp:jingle:transports:s5b:1",
+        "urn:xmpp:jingle:transports:ibb:1",
+        "urn:xmpp:avatar:metadata+notify",
+        "urn:xmpp:message-moderate:0",
+        "http://jabber.org/protocol/tune+notify",
+        "http://jabber.org/protocol/geoloc+notify",
+        "http://jabber.org/protocol/nick+notify",
+        "eu.siacs.conversations.axolotl.devicelist+notify",
+      ],
+      identities: [
+        Identity(
+          category: "client",
+          type: "pc",
+          name: "Gajim"
+        )
+      ]
+    );
 
-      final hash = await calculateCapabilityHash(data, Sha1());
-      expect(hash, "T7fOZrtBnV8sDA2fFTS59vyOyUs=");
-      */
+    final hash = await calculateCapabilityHash(data, Sha1());
+    expect(hash, "T7fOZrtBnV8sDA2fFTS59vyOyUs=");
+    */
   });
 
   test('Test Conversations hash computation', () async {
-      final data = DiscoInfo(
-        [
-          'eu.siacs.conversations.axolotl.devicelist+notify',
-          'http://jabber.org/protocol/caps',
-          'http://jabber.org/protocol/chatstates',
-          'http://jabber.org/protocol/disco#info',
-          'http://jabber.org/protocol/muc',
-          'http://jabber.org/protocol/nick+notify',
-          'jabber:iq:version',
-          'jabber:x:conference',
-          'jabber:x:oob',
-          'storage:bookmarks+notify',
-          'urn:xmpp:avatar:metadata+notify',
-          'urn:xmpp:chat-markers:0',
-          'urn:xmpp:jingle-message:0',
-          'urn:xmpp:jingle:1',
-          'urn:xmpp:jingle:apps:dtls:0',
-          'urn:xmpp:jingle:apps:file-transfer:3',
-          'urn:xmpp:jingle:apps:file-transfer:4',
-          'urn:xmpp:jingle:apps:file-transfer:5',
-          'urn:xmpp:jingle:apps:rtp:1',
-          'urn:xmpp:jingle:apps:rtp:audio',
-          'urn:xmpp:jingle:apps:rtp:video',
-          'urn:xmpp:jingle:jet-omemo:0',
-          'urn:xmpp:jingle:jet:0',
-          'urn:xmpp:jingle:transports:ibb:1',
-          'urn:xmpp:jingle:transports:ice-udp:1',
-          'urn:xmpp:jingle:transports:s5b:1',
-          'urn:xmpp:message-correct:0',
-          'urn:xmpp:ping',
-          'urn:xmpp:receipts',
-          'urn:xmpp:time'
-        ],
-        [
-          Identity(
-            category: 'client',
-            type: 'phone',
-            name: 'Conversations',
-          )
-        ],
-        [],
-        JID.fromString('user@server.local/test'),
-      );
+    final data = DiscoInfo(
+      [
+        'eu.siacs.conversations.axolotl.devicelist+notify',
+        'http://jabber.org/protocol/caps',
+        'http://jabber.org/protocol/chatstates',
+        'http://jabber.org/protocol/disco#info',
+        'http://jabber.org/protocol/muc',
+        'http://jabber.org/protocol/nick+notify',
+        'jabber:iq:version',
+        'jabber:x:conference',
+        'jabber:x:oob',
+        'storage:bookmarks+notify',
+        'urn:xmpp:avatar:metadata+notify',
+        'urn:xmpp:chat-markers:0',
+        'urn:xmpp:jingle-message:0',
+        'urn:xmpp:jingle:1',
+        'urn:xmpp:jingle:apps:dtls:0',
+        'urn:xmpp:jingle:apps:file-transfer:3',
+        'urn:xmpp:jingle:apps:file-transfer:4',
+        'urn:xmpp:jingle:apps:file-transfer:5',
+        'urn:xmpp:jingle:apps:rtp:1',
+        'urn:xmpp:jingle:apps:rtp:audio',
+        'urn:xmpp:jingle:apps:rtp:video',
+        'urn:xmpp:jingle:jet-omemo:0',
+        'urn:xmpp:jingle:jet:0',
+        'urn:xmpp:jingle:transports:ibb:1',
+        'urn:xmpp:jingle:transports:ice-udp:1',
+        'urn:xmpp:jingle:transports:s5b:1',
+        'urn:xmpp:message-correct:0',
+        'urn:xmpp:ping',
+        'urn:xmpp:receipts',
+        'urn:xmpp:time'
+      ],
+      [
+        Identity(
+          category: 'client',
+          type: 'phone',
+          name: 'Conversations',
+        )
+      ],
+      [],
+      null,
+      JID.fromString('user@server.local/test'),
+    );
 
-      final hash = await calculateCapabilityHash(data, Sha1());
-      expect(hash, 'zcIke+Rk13ah4d1pwDG7bEZsVwA=');
+    final hash = await calculateCapabilityHash(data, Sha1());
+    expect(hash, 'zcIke+Rk13ah4d1pwDG7bEZsVwA=');
   });
 }

packages/moxxmpp/test/xeps/xep_0198_test.dart

@@ -17,7 +17,7 @@ Future<void> runOutgoingStanzaHandlers(StreamManagementManager man, Stanza stanz
 
 XmppManagerAttributes mkAttributes(void Function(Stanza) callback) {
   return XmppManagerAttributes(
-    sendStanza: (stanza, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool awaitable = true, bool encrypted = false }) async {
+    sendStanza: (stanza, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool awaitable = true, bool encrypted = false, bool forceEncryption = false, }) async {
       callback(stanza);
 
       return Stanza.message();
@@ -34,7 +34,7 @@ XmppManagerAttributes mkAttributes(void Function(Stanza) callback) {
     isFeatureSupported: (_) => false,
     getFullJID: () => JID.fromString('hallo@example.server/uwu'),
     getSocket: () => StubTCPSocket(play: []),
-    getConnection: () => XmppConnection(TestingReconnectionPolicy(), StubTCPSocket(play: [])),
+    getConnection: () => XmppConnection(TestingReconnectionPolicy(), AlwaysConnectedConnectivityManager(), StubTCPSocket(play: [])),
     getNegotiatorById: getNegotiatorNullStub,
   );
 }
@@ -233,7 +233,11 @@ void main() {
         ]
       );
 
-      final XmppConnection conn = XmppConnection(TestingReconnectionPolicy(), fakeSocket);
+      final XmppConnection conn = XmppConnection(
+        TestingReconnectionPolicy(),
+        AlwaysConnectedConnectivityManager(),
+        fakeSocket,
+      );
       conn.setConnectionSettings(ConnectionSettings(
           jid: JID.fromString('polynomdivision@test.server'),
           password: 'aaaa',
@@ -242,12 +246,13 @@ void main() {
       ),);
       final sm = StreamManagementManager();
       conn.registerManagers([
-          PresenceManager('http://moxxmpp.example'),
-          RosterManager(TestingRosterStateManager('', [])),
-          DiscoManager(),
-          PingManager(),
-          sm,
-          CarbonsManager()..forceEnable(),
+        PresenceManager(),
+        RosterManager(TestingRosterStateManager('', [])),
+        DiscoManager([]),
+        PingManager(),
+        sm,
+        CarbonsManager()..forceEnable(),
+        EntityCapabilitiesManager('http://moxxmpp.example'),
       ]);
       conn.registerFeatureNegotiators(
         [
@@ -343,7 +348,7 @@ void main() {
             '<enabled xmlns="urn:xmpp:sm:3" id="some-long-sm-id" resume="true" />',
           ),
           StringExpectation(
-            "<presence xmlns='jabber:client' from='polynomdivision@test.server/MU29eEZn'><show>chat</show><c xmlns='http://jabber.org/protocol/caps' hash='sha-1' node='http://moxxmpp.example' ver='QRTBC5cg/oYd+UOTYazSQR4zb/I=' /></presence>",
+            "<presence xmlns='jabber:client' from='polynomdivision@test.server/MU29eEZn'><show>chat</show><c xmlns='http://jabber.org/protocol/caps' hash='sha-1' node='http://moxxmpp.example' ver='3QvQ2RAy45XBDhArjxy/vEWMl+E=' /></presence>",
             '<iq type="result" />',
           ),
           StanzaExpectation(
@@ -355,7 +360,11 @@ void main() {
         ]
       );
 
-      final XmppConnection conn = XmppConnection(TestingReconnectionPolicy(), fakeSocket);
+      final XmppConnection conn = XmppConnection(
+        TestingReconnectionPolicy(),
+        AlwaysConnectedConnectivityManager(),
+        fakeSocket,
+      );
       conn.setConnectionSettings(ConnectionSettings(
           jid: JID.fromString('polynomdivision@test.server'),
           password: 'aaaa',
@@ -364,12 +373,13 @@ void main() {
       ),);
       final sm = StreamManagementManager();
       conn.registerManagers([
-          PresenceManager('http://moxxmpp.example'),
+          PresenceManager(),
           RosterManager(TestingRosterStateManager('', [])),
-          DiscoManager(),
+          DiscoManager([]),
           PingManager(),
           sm,
           CarbonsManager()..forceEnable(),
+          EntityCapabilitiesManager('http://moxxmpp.example'),
       ]);
       conn.registerFeatureNegotiators(
         [
@@ -510,7 +520,11 @@ void main() {
         ]
       );
 
-      final XmppConnection conn = XmppConnection(TestingReconnectionPolicy(), fakeSocket);
+      final XmppConnection conn = XmppConnection(
+        TestingReconnectionPolicy(),
+        AlwaysConnectedConnectivityManager(),
+        fakeSocket,
+      );
       conn.setConnectionSettings(ConnectionSettings(
           jid: JID.fromString('polynomdivision@test.server'),
           password: 'aaaa',
@@ -518,9 +532,9 @@ void main() {
           allowPlainAuth: true,
       ),);
       conn.registerManagers([
-          PresenceManager('http://moxxmpp.example'),
+          PresenceManager(),
           RosterManager(TestingRosterStateManager('', [])),
-          DiscoManager(),
+          DiscoManager([]),
           PingManager(),
           StreamManagementManager(),
       ]);
@@ -602,7 +616,11 @@ void main() {
         ]
       );
 
-      final XmppConnection conn = XmppConnection(TestingReconnectionPolicy(), fakeSocket);
+      final XmppConnection conn = XmppConnection(
+        TestingReconnectionPolicy(),
+        AlwaysConnectedConnectivityManager(),
+        fakeSocket,
+      );
       conn.setConnectionSettings(ConnectionSettings(
           jid: JID.fromString('polynomdivision@test.server'),
           password: 'aaaa',
@@ -610,9 +628,9 @@ void main() {
           allowPlainAuth: true,
       ),);
       conn.registerManagers([
-          PresenceManager('http://moxxmpp.example'),
+          PresenceManager(),
           RosterManager(TestingRosterStateManager('', [])),
-          DiscoManager(),
+          DiscoManager([]),
           PingManager(),
           StreamManagementManager(),
       ]);
@@ -694,7 +712,11 @@ void main() {
         ]
       );
 
-      final XmppConnection conn = XmppConnection(TestingReconnectionPolicy(), fakeSocket);
+      final XmppConnection conn = XmppConnection(
+        TestingReconnectionPolicy(),
+        AlwaysConnectedConnectivityManager(),
+        fakeSocket,
+      );
       conn.setConnectionSettings(ConnectionSettings(
           jid: JID.fromString('polynomdivision@test.server'),
           password: 'aaaa',
@@ -702,9 +724,9 @@ void main() {
           allowPlainAuth: true,
       ),);
       conn.registerManagers([
-          PresenceManager('http://moxxmpp.example'),
+          PresenceManager(),
           RosterManager(TestingRosterStateManager('', [])),
-          DiscoManager(),
+          DiscoManager([]),
           PingManager(),
           StreamManagementManager(),
       ]);

packages/moxxmpp/test/xeps/xep_0280_test.dart

@@ -5,7 +5,7 @@ import '../helpers/xmpp.dart';
 void main() {
   test("Test if we're vulnerable against CVE-2020-26547 style vulnerabilities", () async {
     final attributes = XmppManagerAttributes(
-      sendStanza: (stanza, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool retransmitted = false, bool awaitable = true, bool encrypted = false }) async {
+      sendStanza: (stanza, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool retransmitted = false, bool awaitable = true, bool encrypted = false, bool forceEncryption = false, }) async {
         // ignore: avoid_print
         print('==> ${stanza.toXml()}');
         return XMLNode(tag: 'iq', attributes: { 'type': 'result' });
@@ -22,7 +22,7 @@ void main() {
       isFeatureSupported: (_) => false,
       getFullJID: () => JID.fromString('bob@xmpp.example/uwu'),
       getSocket: () => StubTCPSocket(play: []),
-      getConnection: () => XmppConnection(TestingReconnectionPolicy(), StubTCPSocket(play: [])),
+      getConnection: () => XmppConnection(TestingReconnectionPolicy(), AlwaysConnectedConnectivityManager(), StubTCPSocket(play: [])),
       getNegotiatorById: getNegotiatorNullStub,
     );
     final manager = CarbonsManager();

packages/moxxmpp/test/xeps/xep_0352_test.dart

@@ -29,59 +29,62 @@ T? getUnsupportedCSINegotiator<T extends XmppFeatureNegotiatorBase>(String id) {
 
 void main() {
   group('Test the XEP-0352 implementation', () {
-      test('Test setting the CSI state when CSI is unsupported', () {
-          var nonzaSent = false;
-          final csi = CSIManager();
-          csi.register(XmppManagerAttributes(
-              sendStanza: (_, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool retransmitted = false, bool awaitable = true, bool encrypted = false }) async => XMLNode(tag: 'hallo'),
-              sendEvent: (event) {},
-              sendNonza: (nonza) {
-                nonzaSent = true;
-              },
-              getConnectionSettings: () => ConnectionSettings(
-                jid: JID.fromString('some.user@example.server'),
-                password: 'password',
-                useDirectTLS: true,
-                allowPlainAuth: false,
-              ),
-              getManagerById: getManagerNullStub,
-              getNegotiatorById: getUnsupportedCSINegotiator,
-              isFeatureSupported: (_) => false,
-              getFullJID: () => JID.fromString('some.user@example.server/aaaaa'),
-              getSocket: () => StubTCPSocket(play: []),
-              getConnection: () => XmppConnection(TestingReconnectionPolicy(), StubTCPSocket(play: [])),
-            ),
-          );
+    test('Test setting the CSI state when CSI is unsupported', () {
+      var nonzaSent = false;
+      final csi = CSIManager();
+      csi.register(
+        XmppManagerAttributes(
+          sendStanza: (_, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool retransmitted = false, bool awaitable = true, bool encrypted = false, bool forceEncryption = false, }) async => XMLNode(tag: 'hallo'),
+          sendEvent: (event) {},
+          sendNonza: (nonza) {
+            nonzaSent = true;
+          },
+          getConnectionSettings: () => ConnectionSettings(
+            jid: JID.fromString('some.user@example.server'),
+            password: 'password',
+            useDirectTLS: true,
+            allowPlainAuth: false,
+          ),
+          getManagerById: getManagerNullStub,
+          getNegotiatorById: getUnsupportedCSINegotiator,
+          isFeatureSupported: (_) => false,
+          getFullJID: () => JID.fromString('some.user@example.server/aaaaa'),
+          getSocket: () => StubTCPSocket(play: []),
+          getConnection: () => XmppConnection(TestingReconnectionPolicy(), AlwaysConnectedConnectivityManager(), StubTCPSocket(play: [])),
+        ),
+      );
 
-          csi.setActive();
-          csi.setInactive();
+      csi.setActive();
+      csi.setInactive();
 
-          expect(nonzaSent, false, reason: 'Expected that no nonza is sent');
-      });
-      test('Test setting the CSI state when CSI is supported', () {
-          final csi = CSIManager();
-          csi.register(XmppManagerAttributes(
-              sendStanza: (_, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool retransmitted = false, bool awaitable = true, bool encrypted = false }) async => XMLNode(tag: 'hallo'),
-              sendEvent: (event) {},
-              sendNonza: (nonza) {
-                expect(nonza.attributes['xmlns'] == csiXmlns, true, reason: "Expected only nonzas with XMLNS '$csiXmlns'");
-              },
-              getConnectionSettings: () => ConnectionSettings(
-                jid: JID.fromString('some.user@example.server'),
-                password: 'password',
-                useDirectTLS: true,
-                allowPlainAuth: false,
-              ),
-              getManagerById: getManagerNullStub,
-              getNegotiatorById: getSupportedCSINegotiator,
-              isFeatureSupported: (_) => false,
-              getFullJID: () => JID.fromString('some.user@example.server/aaaaa'),
-              getSocket: () => StubTCPSocket(play: []),
-              getConnection: () => XmppConnection(TestingReconnectionPolicy(), StubTCPSocket(play: [])),
-          ),);
+      expect(nonzaSent, false, reason: 'Expected that no nonza is sent');
+    });
+    test('Test setting the CSI state when CSI is supported', () {
+      final csi = CSIManager();
+      csi.register(
+        XmppManagerAttributes(
+          sendStanza: (_, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool retransmitted = false, bool awaitable = true, bool encrypted = false, bool forceEncryption = false, }) async => XMLNode(tag: 'hallo'),
+          sendEvent: (event) {},
+          sendNonza: (nonza) {
+            expect(nonza.attributes['xmlns'] == csiXmlns, true, reason: "Expected only nonzas with XMLNS '$csiXmlns'");
+          },
+          getConnectionSettings: () => ConnectionSettings(
+            jid: JID.fromString('some.user@example.server'),
+            password: 'password',
+            useDirectTLS: true,
+            allowPlainAuth: false,
+          ),
+          getManagerById: getManagerNullStub,
+          getNegotiatorById: getSupportedCSINegotiator,
+          isFeatureSupported: (_) => false,
+          getFullJID: () => JID.fromString('some.user@example.server/aaaaa'),
+          getSocket: () => StubTCPSocket(play: []),
+          getConnection: () => XmppConnection(TestingReconnectionPolicy(), AlwaysConnectedConnectivityManager(), StubTCPSocket(play: [])),
+        ),
+      );
 
-          csi.setActive();
-          csi.setInactive();
-      });
+      csi.setActive();
+      csi.setInactive();
+    });
   });
 }

packages/moxxmpp/test/xeps/xep_0363_test.dart

@@ -3,52 +3,52 @@ import 'package:test/test.dart';
 
 void main() {
   group('Test the XEP-0363 header preparation', () {
-      test('invariance', () {
-          final headers = {
-            'authorization': 'Basic Base64String==',
-            'cookie': 'foo=bar; user=romeo'
-          };
-          expect(
-            prepareHeaders(headers),
-            headers,
-          );
-      });
-      test('invariance through uppercase', () {
-          final headers = {
-            'Authorization': 'Basic Base64String==',
-            'Cookie': 'foo=bar; user=romeo'
-          };
-          expect(
-            prepareHeaders(headers),
-            headers,
-          );
-      });
-      test('remove unspecified headers', () {
-          final headers = {
-            'Authorization': 'Basic Base64String==',
-            'Cookie': 'foo=bar; user=romeo',
-            'X-Tracking': 'Base64String=='
-          };
-          expect(
-            prepareHeaders(headers),
-            {
-              'Authorization': 'Basic Base64String==',
-              'Cookie': 'foo=bar; user=romeo',
-            }
-          );
-      });
-      test('remove newlines', () {
-          final headers = {
-            'Authorization': '\n\nBasic Base64String==\n\n',
-            '\nCookie\r\n': 'foo=bar; user=romeo',
-          };
-          expect(
-            prepareHeaders(headers),
-            {
-              'Authorization': 'Basic Base64String==',
-              'Cookie': 'foo=bar; user=romeo',
-            }
-          );
-      });
+    test('invariance', () {
+      final headers = {
+        'authorization': 'Basic Base64String==',
+        'cookie': 'foo=bar; user=romeo'
+      };
+      expect(
+        prepareHeaders(headers),
+        headers,
+      );
+    });
+    test('invariance through uppercase', () {
+      final headers = {
+        'Authorization': 'Basic Base64String==',
+        'Cookie': 'foo=bar; user=romeo'
+      };
+      expect(
+        prepareHeaders(headers),
+        headers,
+      );
+    });
+    test('remove unspecified headers', () {
+      final headers = {
+        'Authorization': 'Basic Base64String==',
+        'Cookie': 'foo=bar; user=romeo',
+        'X-Tracking': 'Base64String=='
+      };
+      expect(
+        prepareHeaders(headers),
+        {
+          'Authorization': 'Basic Base64String==',
+          'Cookie': 'foo=bar; user=romeo',
+        }
+      );
+    });
+    test('remove newlines', () {
+      final headers = {
+        'Authorization': '\n\nBasic Base64String==\n\n',
+        '\nCookie\r\n': 'foo=bar; user=romeo',
+      };
+      expect(
+        prepareHeaders(headers),
+        {
+          'Authorization': 'Basic Base64String==',
+          'Cookie': 'foo=bar; user=romeo',
+        }
+      );
+    });
   });
 }

packages/moxxmpp/test/xmpp_test.dart

@@ -9,7 +9,7 @@ Future<bool> testRosterManager(String bareJid, String resource, String stanzaStr
   var eventTriggered = false;
   final roster = RosterManager(TestingRosterStateManager('', []));
   roster.register(XmppManagerAttributes(
-      sendStanza: (_, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool retransmitted = false, bool awaitable = true, bool encrypted = false }) async => XMLNode(tag: 'hallo'),
+      sendStanza: (_, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool retransmitted = false, bool awaitable = true, bool encrypted = false, bool forceEncryption = false, }) async => XMLNode(tag: 'hallo'),
       sendEvent: (event) {
         eventTriggered = true;
       },
@@ -25,7 +25,7 @@ Future<bool> testRosterManager(String bareJid, String resource, String stanzaStr
       isFeatureSupported: (_) => false,
       getFullJID: () => JID.fromString('$bareJid/$resource'),
       getSocket: () => StubTCPSocket(play: []),
-      getConnection: () => XmppConnection(TestingReconnectionPolicy(), StubTCPSocket(play: [])),
+      getConnection: () => XmppConnection(TestingReconnectionPolicy(), AlwaysConnectedConnectivityManager(), StubTCPSocket(play: [])),
   ),);
 
   final stanza = Stanza.fromXMLNode(XMLNode.fromString(stanzaString));
@@ -118,7 +118,10 @@ void main() {
         ],
       );
       // TODO: This test is broken since we query the server and enable carbons
-      final XmppConnection conn = XmppConnection(TestingReconnectionPolicy(), fakeSocket);
+      final XmppConnection conn = XmppConnection(
+        TestingReconnectionPolicy(),
+        AlwaysConnectedConnectivityManager(),
+        fakeSocket);
       conn.setConnectionSettings(ConnectionSettings(
           jid: JID.fromString('polynomdivision@test.server'),
           password: 'aaaa',
@@ -126,11 +129,12 @@ void main() {
           allowPlainAuth: true,
       ),);
       conn.registerManagers([
-        PresenceManager('http://moxxmpp.example'),
+        PresenceManager(),
         RosterManager(TestingRosterStateManager('', [])),
-        DiscoManager(),
+        DiscoManager([]),
         PingManager(),
         StreamManagementManager(),
+        EntityCapabilitiesManager('http://moxxmpp.example'),
       ]);
       conn.registerFeatureNegotiators(
         [
@@ -172,7 +176,11 @@ void main() {
         ],
       );
       var receivedEvent = false;
-      final XmppConnection conn = XmppConnection(TestingReconnectionPolicy(), fakeSocket);
+      final XmppConnection conn = XmppConnection(
+        TestingReconnectionPolicy(),
+        AlwaysConnectedConnectivityManager(),
+        fakeSocket,
+      );
       conn.setConnectionSettings(ConnectionSettings(
         jid: JID.fromString('polynomdivision@test.server'),
         password: 'aaaa',
@@ -180,10 +188,11 @@ void main() {
         allowPlainAuth: true,
       ),);
       conn.registerManagers([
-        PresenceManager('http://moxxmpp.example'),
+        PresenceManager(),
         RosterManager(TestingRosterStateManager('', [])),
-        DiscoManager(),
+        DiscoManager([]),
         PingManager(),
+        EntityCapabilitiesManager('http://moxxmpp.example'),
       ]);
       conn.registerFeatureNegotiators([
         SaslPlainNegotiator()
@@ -226,7 +235,11 @@ void main() {
         ],
       );
       var receivedEvent = false;
-      final XmppConnection conn = XmppConnection(TestingReconnectionPolicy(), fakeSocket);
+      final XmppConnection conn = XmppConnection(
+        TestingReconnectionPolicy(),
+        AlwaysConnectedConnectivityManager(),
+        fakeSocket,
+      );
       conn.setConnectionSettings(ConnectionSettings(
           jid: JID.fromString('polynomdivision@test.server'),
           password: 'aaaa',
@@ -234,10 +247,11 @@ void main() {
           allowPlainAuth: true,
       ),);
       conn.registerManagers([
-        PresenceManager('http://moxxmpp.example'),
+        PresenceManager(),
         RosterManager(TestingRosterStateManager('', [])),
-        DiscoManager(),
+        DiscoManager([]),
         PingManager(),
+        EntityCapabilitiesManager('http://moxxmpp.example'),
       ]);
       conn.registerFeatureNegotiators([
         SaslPlainNegotiator()
@@ -310,7 +324,7 @@ void main() {
           var eventTriggered = false;
           final roster = RosterManager(TestingRosterStateManager('', []));
           roster.register(XmppManagerAttributes(
-              sendStanza: (_, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool retransmitted = false, bool awaitable = true, bool encrypted = false }) async => XMLNode(tag: 'hallo'),
+              sendStanza: (_, { StanzaFromType addFrom = StanzaFromType.full, bool addId = true, bool retransmitted = false, bool awaitable = true, bool encrypted = false, bool forceEncryption = false, }) async => XMLNode(tag: 'hallo'),
               sendEvent: (event) {
                 eventTriggered = true;
               },
@@ -326,7 +340,7 @@ void main() {
               isFeatureSupported: (_) => false,
               getFullJID: () => JID.fromString('some.user@example.server/aaaaa'),
               getSocket: () => StubTCPSocket(play: []),
-              getConnection: () => XmppConnection(TestingReconnectionPolicy(), StubTCPSocket(play: [])),
+              getConnection: () => XmppConnection(TestingReconnectionPolicy(), AlwaysConnectedConnectivityManager(), StubTCPSocket(play: [])),
           ),);
 
           // NOTE: Based on https://gultsch.de/gajim_roster_push_and_message_interception.html