packages/moxxmpp/lib/src/xeps/xep_0054.dart

@@ -56,17 +56,17 @@ class VCardManager extends XmppManagerBase {
     final x = presence.firstTag('x', xmlns: vCardTempUpdate)!;
     final hash = x.firstTag('photo')!.innerText();
 
-    final from = JID.fromString(presence.from!).toBare();
+    final from = JID.fromString(presence.from!).toBare().toString();
     final lastHash = _lastHash[from];
     if (lastHash != hash) {
-      _lastHash[from.toString()] = hash;
+      _lastHash[from] = hash;
       final vcardResult = await requestVCard(from);
 
       if (vcardResult.isType<VCard>()) {
         final binval = vcardResult.get<VCard>().photo?.binval;
         if (binval != null) {
           getAttributes().sendEvent(
-            VCardAvatarUpdatedEvent(from, binval, hash),
+            VCardAvatarUpdatedEvent(JID.fromString(from), binval, hash),
           );
         } else {
           logger.warning('No avatar data found');
@@ -98,11 +98,11 @@ class VCardManager extends XmppManagerBase {
     );
   }
 
-  Future<Result<VCardError, VCard>> requestVCard(JID jid) async {
+  Future<Result<VCardError, VCard>> requestVCard(String jid) async {
     final result = (await getAttributes().sendStanza(
       StanzaDetails(
         Stanza.iq(
-          to: jid.toString(),
+          to: jid,
           type: 'get',
           children: [
             XMLNode.xmlns(

packages/moxxmpp/lib/src/xeps/xep_0447.dart

@@ -151,17 +151,14 @@ class SFSManager extends XmppManagerBase {
     // TODO(Unknown): Consider all sources?
     final source = data.sources.first;
     OOBData? oob;
-    MessageBodyData? body;
     if (source is StatelessFileSharingUrlSource && data.includeOOBFallback) {
       // SFS recommends OOB as a fallback
       oob = OOBData(source.url, null);
-      body = MessageBodyData(source.url);
     }
 
     return [
       data.toXML(),
       if (oob != null) oob.toXML(),
-      if (body != null) body.toXML(),
     ];
   }