From ac8433f51f0e1d1bd6c528c379f8beea3f0829fc Mon Sep 17 00:00:00 2001 From: "Alexander \"PapaTutuWawa" Date: Sun, 2 Apr 2023 23:33:53 +0200 Subject: [PATCH] chore(core): Refactor RFC6120 implementations --- packages/moxxmpp/lib/moxxmpp.dart | 13 ++++++------- packages/moxxmpp/lib/src/negotiators/sasl2.dart | 1 - .../rfc_6120}/resource_binding.dart | 0 .../{negotiators => rfcs/rfc_6120}/sasl/errors.dart | 0 .../src/{negotiators => rfcs/rfc_6120}/sasl/kv.dart | 0 .../rfc_6120}/sasl/negotiator.dart | 0 .../{negotiators => rfcs/rfc_6120}/sasl/nonza.dart | 0 .../{negotiators => rfcs/rfc_6120}/sasl/plain.dart | 4 ++-- .../{negotiators => rfcs/rfc_6120}/sasl/scram.dart | 6 +++--- .../{negotiators => rfcs/rfc_6120}/starttls.dart | 0 .../moxxmpp/lib/src/xeps/xep_0388/negotiators.dart | 2 +- .../moxxmpp/lib/src/xeps/xep_0388/xep_0388.dart | 2 +- packages/moxxmpp/test/sasl/kv_test.dart | 2 +- 13 files changed, 14 insertions(+), 16 deletions(-) delete mode 100644 packages/moxxmpp/lib/src/negotiators/sasl2.dart rename packages/moxxmpp/lib/src/{negotiators => rfcs/rfc_6120}/resource_binding.dart (100%) rename packages/moxxmpp/lib/src/{negotiators => rfcs/rfc_6120}/sasl/errors.dart (100%) rename packages/moxxmpp/lib/src/{negotiators => rfcs/rfc_6120}/sasl/kv.dart (100%) rename packages/moxxmpp/lib/src/{negotiators => rfcs/rfc_6120}/sasl/negotiator.dart (100%) rename packages/moxxmpp/lib/src/{negotiators => rfcs/rfc_6120}/sasl/nonza.dart (100%) rename packages/moxxmpp/lib/src/{negotiators => rfcs/rfc_6120}/sasl/plain.dart (95%) rename packages/moxxmpp/lib/src/{negotiators => rfcs/rfc_6120}/sasl/scram.dart (98%) rename packages/moxxmpp/lib/src/{negotiators => rfcs/rfc_6120}/starttls.dart (100%) diff --git a/packages/moxxmpp/lib/moxxmpp.dart b/packages/moxxmpp/lib/moxxmpp.dart index 2a349fc..8a9dd9b 100644 --- a/packages/moxxmpp/lib/moxxmpp.dart +++ b/packages/moxxmpp/lib/moxxmpp.dart @@ -18,18 +18,17 @@ export 'package:moxxmpp/src/namespaces.dart'; export 'package:moxxmpp/src/negotiators/manager.dart'; export 'package:moxxmpp/src/negotiators/namespaces.dart'; export 'package:moxxmpp/src/negotiators/negotiator.dart'; -export 'package:moxxmpp/src/negotiators/resource_binding.dart'; -export 'package:moxxmpp/src/negotiators/sasl/errors.dart'; -export 'package:moxxmpp/src/negotiators/sasl/negotiator.dart'; -export 'package:moxxmpp/src/negotiators/sasl/plain.dart'; -export 'package:moxxmpp/src/negotiators/sasl/scram.dart'; -export 'package:moxxmpp/src/negotiators/sasl2.dart'; -export 'package:moxxmpp/src/negotiators/starttls.dart'; export 'package:moxxmpp/src/ping.dart'; export 'package:moxxmpp/src/presence.dart'; export 'package:moxxmpp/src/reconnect.dart'; export 'package:moxxmpp/src/rfcs/rfc_2782.dart'; export 'package:moxxmpp/src/rfcs/rfc_4790.dart'; +export 'package:moxxmpp/src/rfcs/rfc_6120/resource_binding.dart'; +export 'package:moxxmpp/src/rfcs/rfc_6120/sasl/errors.dart'; +export 'package:moxxmpp/src/rfcs/rfc_6120/sasl/negotiator.dart'; +export 'package:moxxmpp/src/rfcs/rfc_6120/sasl/plain.dart'; +export 'package:moxxmpp/src/rfcs/rfc_6120/sasl/scram.dart'; +export 'package:moxxmpp/src/rfcs/rfc_6120/starttls.dart'; export 'package:moxxmpp/src/roster/errors.dart'; export 'package:moxxmpp/src/roster/roster.dart'; export 'package:moxxmpp/src/roster/state.dart'; diff --git a/packages/moxxmpp/lib/src/negotiators/sasl2.dart b/packages/moxxmpp/lib/src/negotiators/sasl2.dart deleted file mode 100644 index 8b13789..0000000 --- a/packages/moxxmpp/lib/src/negotiators/sasl2.dart +++ /dev/null @@ -1 +0,0 @@ - diff --git a/packages/moxxmpp/lib/src/negotiators/resource_binding.dart b/packages/moxxmpp/lib/src/rfcs/rfc_6120/resource_binding.dart similarity index 100% rename from packages/moxxmpp/lib/src/negotiators/resource_binding.dart rename to packages/moxxmpp/lib/src/rfcs/rfc_6120/resource_binding.dart diff --git a/packages/moxxmpp/lib/src/negotiators/sasl/errors.dart b/packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/errors.dart similarity index 100% rename from packages/moxxmpp/lib/src/negotiators/sasl/errors.dart rename to packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/errors.dart diff --git a/packages/moxxmpp/lib/src/negotiators/sasl/kv.dart b/packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/kv.dart similarity index 100% rename from packages/moxxmpp/lib/src/negotiators/sasl/kv.dart rename to packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/kv.dart diff --git a/packages/moxxmpp/lib/src/negotiators/sasl/negotiator.dart b/packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/negotiator.dart similarity index 100% rename from packages/moxxmpp/lib/src/negotiators/sasl/negotiator.dart rename to packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/negotiator.dart diff --git a/packages/moxxmpp/lib/src/negotiators/sasl/nonza.dart b/packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/nonza.dart similarity index 100% rename from packages/moxxmpp/lib/src/negotiators/sasl/nonza.dart rename to packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/nonza.dart diff --git a/packages/moxxmpp/lib/src/negotiators/sasl/plain.dart b/packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/plain.dart similarity index 95% rename from packages/moxxmpp/lib/src/negotiators/sasl/plain.dart rename to packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/plain.dart index 2d0650f..573762c 100644 --- a/packages/moxxmpp/lib/src/negotiators/sasl/plain.dart +++ b/packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/plain.dart @@ -3,8 +3,8 @@ import 'package:logging/logging.dart'; import 'package:moxxmpp/src/events.dart'; import 'package:moxxmpp/src/negotiators/namespaces.dart'; import 'package:moxxmpp/src/negotiators/negotiator.dart'; -import 'package:moxxmpp/src/negotiators/sasl/errors.dart'; -import 'package:moxxmpp/src/negotiators/sasl/nonza.dart'; +import 'package:moxxmpp/src/rfcs/rfc_6120/sasl/errors.dart'; +import 'package:moxxmpp/src/rfcs/rfc_6120/sasl/nonza.dart'; import 'package:moxxmpp/src/stringxml.dart'; import 'package:moxxmpp/src/types/result.dart'; import 'package:moxxmpp/src/xeps/xep_0388/negotiators.dart'; diff --git a/packages/moxxmpp/lib/src/negotiators/sasl/scram.dart b/packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/scram.dart similarity index 98% rename from packages/moxxmpp/lib/src/negotiators/sasl/scram.dart rename to packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/scram.dart index e44d9a7..9ea570b 100644 --- a/packages/moxxmpp/lib/src/negotiators/sasl/scram.dart +++ b/packages/moxxmpp/lib/src/rfcs/rfc_6120/sasl/scram.dart @@ -6,9 +6,9 @@ import 'package:moxxmpp/src/events.dart'; import 'package:moxxmpp/src/namespaces.dart'; import 'package:moxxmpp/src/negotiators/namespaces.dart'; import 'package:moxxmpp/src/negotiators/negotiator.dart'; -import 'package:moxxmpp/src/negotiators/sasl/errors.dart'; -import 'package:moxxmpp/src/negotiators/sasl/kv.dart'; -import 'package:moxxmpp/src/negotiators/sasl/nonza.dart'; +import 'package:moxxmpp/src/rfcs/rfc_6120/sasl/errors.dart'; +import 'package:moxxmpp/src/rfcs/rfc_6120/sasl/kv.dart'; +import 'package:moxxmpp/src/rfcs/rfc_6120/sasl/nonza.dart'; import 'package:moxxmpp/src/stringxml.dart'; import 'package:moxxmpp/src/types/result.dart'; import 'package:moxxmpp/src/xeps/xep_0388/negotiators.dart'; diff --git a/packages/moxxmpp/lib/src/negotiators/starttls.dart b/packages/moxxmpp/lib/src/rfcs/rfc_6120/starttls.dart similarity index 100% rename from packages/moxxmpp/lib/src/negotiators/starttls.dart rename to packages/moxxmpp/lib/src/rfcs/rfc_6120/starttls.dart diff --git a/packages/moxxmpp/lib/src/xeps/xep_0388/negotiators.dart b/packages/moxxmpp/lib/src/xeps/xep_0388/negotiators.dart index 4a95a70..948930f 100644 --- a/packages/moxxmpp/lib/src/xeps/xep_0388/negotiators.dart +++ b/packages/moxxmpp/lib/src/xeps/xep_0388/negotiators.dart @@ -1,5 +1,5 @@ import 'package:moxxmpp/src/negotiators/negotiator.dart'; -import 'package:moxxmpp/src/negotiators/sasl/negotiator.dart'; +import 'package:moxxmpp/src/rfcs/rfc_6120/sasl/negotiator.dart'; import 'package:moxxmpp/src/stringxml.dart'; import 'package:moxxmpp/src/types/result.dart'; diff --git a/packages/moxxmpp/lib/src/xeps/xep_0388/xep_0388.dart b/packages/moxxmpp/lib/src/xeps/xep_0388/xep_0388.dart index 18067bc..d28f760 100644 --- a/packages/moxxmpp/lib/src/xeps/xep_0388/xep_0388.dart +++ b/packages/moxxmpp/lib/src/xeps/xep_0388/xep_0388.dart @@ -2,7 +2,7 @@ import 'package:moxxmpp/src/jid.dart'; import 'package:moxxmpp/src/namespaces.dart'; import 'package:moxxmpp/src/negotiators/namespaces.dart'; import 'package:moxxmpp/src/negotiators/negotiator.dart'; -import 'package:moxxmpp/src/negotiators/sasl/errors.dart'; +import 'package:moxxmpp/src/rfcs/rfc_6120/sasl/errors.dart'; import 'package:moxxmpp/src/stringxml.dart'; import 'package:moxxmpp/src/types/result.dart'; import 'package:moxxmpp/src/xeps/xep_0388/errors.dart'; diff --git a/packages/moxxmpp/test/sasl/kv_test.dart b/packages/moxxmpp/test/sasl/kv_test.dart index 4b601fb..5717ac5 100644 --- a/packages/moxxmpp/test/sasl/kv_test.dart +++ b/packages/moxxmpp/test/sasl/kv_test.dart @@ -1,4 +1,4 @@ -import 'package:moxxmpp/src/negotiators/sasl/kv.dart'; +import 'package:moxxmpp/src/rfcs/rfc_6120/sasl/kv.dart'; import 'package:test/test.dart'; void main() {