From bfeb9858e35a16c3aaf30af5973ab9da33043474 Mon Sep 17 00:00:00 2001
From: "Alexander \"PapaTutuWawa" <papatutuwawa@polynom.me>
Date: Wed, 27 Jul 2022 22:13:33 +0200
Subject: [PATCH] style: Migrate to very_good_analysis

---
 packages/moxdns/analysis_options.yaml | 12 ++++++++----
 packages/moxdns/example/lib/main.dart |  8 +++-----
 packages/moxdns/lib/moxdns.dart       | 15 ++++-----------
 packages/moxdns/pubspec.yaml          |  9 +++++----
 4 files changed, 20 insertions(+), 24 deletions(-)

diff --git a/packages/moxdns/analysis_options.yaml b/packages/moxdns/analysis_options.yaml
index a5744c1..b3a83ec 100644
--- a/packages/moxdns/analysis_options.yaml
+++ b/packages/moxdns/analysis_options.yaml
@@ -1,4 +1,8 @@
-include: package:flutter_lints/flutter.yaml
-
-# Additional information about this file can be found at
-# https://dart.dev/guides/language/analysis-options
+include: package:very_good_analysis/analysis_options.yaml
+linter:
+  rules:
+    public_member_api_docs: false
+    lines_longer_than_80_chars: false
+    use_setters_to_change_properties: false
+    avoid_positional_boolean_parameters: false
+    avoid_bool_literals_in_conditional_expressions: false
diff --git a/packages/moxdns/example/lib/main.dart b/packages/moxdns/example/lib/main.dart
index 24e35fb..7305322 100644
--- a/packages/moxdns/example/lib/main.dart
+++ b/packages/moxdns/example/lib/main.dart
@@ -1,6 +1,6 @@
+// ignore_for_file: avoid_print
 import 'package:flutter/material.dart';
-
-import "package:moxdns/moxdns.dart";
+import 'package:moxdns/moxdns.dart';
 
 void main() {
   runApp(const MyApp());
@@ -50,8 +50,6 @@ class MyHomePage extends StatefulWidget {
 }
 
 class _MyHomePageState extends State<MyHomePage> {
-  int _counter = 0;
-
   Future<void> _query() async {
     final results = await MoxdnsPlugin.srvQuery("_xmpps-client._tcp.polynom.me", false);
     for (final r in results) {
@@ -100,7 +98,7 @@ class _MyHomePageState extends State<MyHomePage> {
               'You have pushed the button this many times:',
             ),
             Text(
-              '$_counter',
+              '0',
               style: Theme.of(context).textTheme.headline4,
             ),
           ],
diff --git a/packages/moxdns/lib/moxdns.dart b/packages/moxdns/lib/moxdns.dart
index 02b1567..9d2f6a8 100644
--- a/packages/moxdns/lib/moxdns.dart
+++ b/packages/moxdns/lib/moxdns.dart
@@ -1,6 +1,5 @@
-import "package:moxdns_platform_interface/moxdns_platform_interface.dart";
-
-export "package:moxdns_platform_interface/moxdns_platform_interface.dart" show SrvRecord;
+import 'package:moxdns_platform_interface/moxdns_platform_interface.dart';
+export 'package:moxdns_platform_interface/moxdns_platform_interface.dart' show SrvRecord;
 
 class MoxdnsStubPlugin extends MoxdnsPlatform {
   @override
@@ -8,17 +7,11 @@ class MoxdnsStubPlugin extends MoxdnsPlatform {
 }
 
 abstract class MoxdnsPlugin {
-  static MoxdnsPlatform _platform = MoxdnsStubPlugin();
-
-  static MoxdnsPlatform get platform => _platform;
-
-  static set platform(MoxdnsPlatform platform) {
-    _platform = platform;
-  }
+  static MoxdnsPlatform platform = MoxdnsStubPlugin();
 
   /// Perform a DNS SRV query for [domain], optionally using DNSSEC if [dnssec] is true.
   /// The order of the results is abitrary.
   static Future<List<SrvRecord>> srvQuery(String domain, bool dnssec) async {
-    return await platform.srvQuery(domain, dnssec);
+    return platform.srvQuery(domain, dnssec);
   }
 }
diff --git a/packages/moxdns/pubspec.yaml b/packages/moxdns/pubspec.yaml
index 8b54804..cd3e20c 100644
--- a/packages/moxdns/pubspec.yaml
+++ b/packages/moxdns/pubspec.yaml
@@ -20,17 +20,18 @@ dependencies:
   flutter:
     sdk: flutter
 
-  moxdns_platform_interface:
-    hosted: https://pub.polynom.me
-    version: 0.1.1
   moxdns_android:
     hosted: https://pub.polynom.me
     version: 0.1.1
   moxdns_linux:
     hosted: https://pub.polynom.me
     version: 0.1.1
+  moxdns_platform_interface:
+    hosted: https://pub.polynom.me
+    version: 0.1.1
 
 dev_dependencies:
+  flutter_lints: ^2.0.0
   flutter_test:
     sdk: flutter
-  flutter_lints: ^2.0.0
+  very_good_analysis: 2.4.0