PapaTutuWawa/gpu-screen-recorder
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not use p4, p7 with old ffmpeg that doesn't have those options yet

Browse Source
This commit is contained in:
dec05eba 2022-10-12 04:53:56 +02:00
parent 9d185f3091
commit dc20d1eddb
1 changed files with 49 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/main.cpp
View File

@ -793,7 +793,36 @@ static void open_video(AVCodecContext *codec_context,
codec_context->hw_device_ctx = *device_ctx; codec_context->hw_device_ctx = *device_ctx;
codec_context->hw_frames_ctx = frame_context; codec_context->hw_frames_ctx = frame_context;
bool supports_p4 = false;
bool supports_p7 = false;
const AVOption *opt = nullptr;
while((opt = av_opt_next(codec_context->priv_data, opt))) {
if(opt->type == AV_OPT_TYPE_CONST) {
if(strcmp(opt->name, "p4") == 0)
supports_p4 = true;
else if(strcmp(opt->name, "p7") == 0)
supports_p7 = true;
}
}
AVDictionary *options = nullptr; AVDictionary *options = nullptr;
if(very_old_gpu || !supports_p7) {
switch(video_quality) {
case VideoQuality::MEDIUM:
av_dict_set_int(&options, "qp", 37, 0);
break;
case VideoQuality::HIGH:
av_dict_set_int(&options, "qp", 32, 0);
break;
case VideoQuality::VERY_HIGH:
av_dict_set_int(&options, "qp", 27, 0);
break;
case VideoQuality::ULTRA:
av_dict_set_int(&options, "qp", 21, 0);
break;
}
} else {
switch(video_quality) { switch(video_quality) {
case VideoQuality::MEDIUM: case VideoQuality::MEDIUM:
av_dict_set_int(&options, "qp", 40, 0); av_dict_set_int(&options, "qp", 40, 0);
@ -808,6 +837,11 @@ static void open_video(AVCodecContext *codec_context,
av_dict_set_int(&options, "qp", 24, 0); av_dict_set_int(&options, "qp", 24, 0);
break; break;
} }
}
if(!supports_p4 && !supports_p7) {
fprintf(stderr, "Info: your ffmpeg version is outdated. It's recommended that you use the flatpak version of gpu-screen-recorder version instead, which you can find at https://flathub.org/apps/details/com.dec05eba.gpu_screen_recorder\n");
}
//if(is_livestream) { //if(is_livestream) {
// av_dict_set_int(&options, "zerolatency", 1, 0); // av_dict_set_int(&options, "zerolatency", 1, 0);
@ -819,9 +853,9 @@ static void open_video(AVCodecContext *codec_context,
// with pretty good performance but you now have to choose p1-p7, which are gpu agnostic and on // with pretty good performance but you now have to choose p1-p7, which are gpu agnostic and on
// older gpus p5-p7 slow the gpu down to a crawl... // older gpus p5-p7 slow the gpu down to a crawl...
// "hq" is now just an alias for p7 in ffmpeg :( // "hq" is now just an alias for p7 in ffmpeg :(
if(very_old_gpu) if(very_old_gpu && supports_p4)
av_dict_set(&options, "preset", "p4", 0); av_dict_set(&options, "preset", "p4", 0);
else else if(supports_p7)
av_dict_set(&options, "preset", "p7", 0); av_dict_set(&options, "preset", "p7", 0);
av_dict_set(&options, "tune", "hq", 0); av_dict_set(&options, "tune", "hq", 0);
av_dict_set(&options, "rc", "constqp", 0); av_dict_set(&options, "rc", "constqp", 0);