From 4de23c25561bae0026a97f7ed9d3d64f3d558aaa Mon Sep 17 00:00:00 2001 From: dec05eba Date: Sat, 22 Jul 2023 05:13:23 +0200 Subject: [PATCH] Temp disable cursor fix --- TODO | 1 + src/capture/kms_vaapi.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 286f2ed..3232daf 100644 --- a/TODO +++ b/TODO @@ -83,3 +83,4 @@ Support screen rotation. When nvidia supports hardware cursor then capture the cursor. Right now the cursor is captured because it's a software cursor so it's composed on the dma buf. CPU usage is pretty high on AMD/Intel/(Nvidia(wayland)), why? opening and closing fds, creating egl, cuda association, is slow when done every frame. Test if desktop portal screencast has better performance. +Fix cursor offset in kms_vaapi when capturing with multiple monitors. \ No newline at end of file diff --git a/src/capture/kms_vaapi.c b/src/capture/kms_vaapi.c index e49c4d6..00404a6 100644 --- a/src/capture/kms_vaapi.c +++ b/src/capture/kms_vaapi.c @@ -470,8 +470,9 @@ static int gsr_capture_kms_vaapi_capture(gsr_capture *cap, AVFrame *frame) { return -1; /* Hide cursor when it's on another display */ - if(!capture_is_combined_plane && cursor_drm_fd && cursor_drm_fd->connector_id != drm_fd->connector_id) - cursor_drm_fd = NULL; + // TODO: + //if(!capture_is_combined_plane && cursor_drm_fd && cursor_drm_fd->connector_id != drm_fd->connector_id) + // cursor_drm_fd = NULL; // TODO: This causes a crash sometimes on steam deck, why? is it a driver bug? a vaapi pure version doesn't cause a crash. // Even ffmpeg kmsgrab causes this crash. The error is: