PapaTutuWawa/etesync-server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

CollectionItem: always run both serializers when serializing.

Browse Source
This commit is contained in:
Tom Hacohen 2020-05-19 12:57:18 +03:00
parent 306e7dcd11
commit 23dcbc1f9e
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
django_etesync/views.py
View File

@ -236,9 +236,13 @@ class CollectionItemViewSet(BaseViewSet):
items = request.data.get('items') items = request.data.get('items')
deps = request.data.get('deps', None) deps = request.data.get('deps', None)
# FIXME: It should just be one serializer
serializer = self.get_serializer_class()(data=items, context=self.get_serializer_context(), many=True) serializer = self.get_serializer_class()(data=items, context=self.get_serializer_context(), many=True)
deps_serializer = CollectionItemDepSerializer(data=deps, context=self.get_serializer_context(), many=True) deps_serializer = CollectionItemDepSerializer(data=deps, context=self.get_serializer_context(), many=True)
if serializer.is_valid() and (deps is None or deps_serializer.is_valid()):
ser_valid = serializer.is_valid()
deps_ser_valid = (deps is None or deps_serializer.is_valid())
if ser_valid and deps_ser_valid:
try: try:
with transaction.atomic(): with transaction.atomic():
collections = serializer.save(collection=collection_object) collections = serializer.save(collection=collection_object)